Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001789Dwarf FortressDwarf Mode -- Moodspublic2010-05-06 17:282016-07-04 16:23
ReporterImmoralFibre 
Assigned Tolethosor 
PrioritynormalSeveritytextReproducibilityhave not tried
StatusconfirmedResolutionopen 
Platformx86_64OSWindows XP x64OS Version
Product Version0.31.03 
Target VersionFixed in Version 
Summary0001789: Noble profession change announcements always list nobles' current profession
DescriptionMy bookkeeper was also a competent carpenter. He had a fey mood and ascended to legendary carpenter. However, after the item creation message, I get the following:

"Lorbam Idosonul has become a bookkeeper."

I'm guessing that behind the scenes, the code is setting the new skill level, then using the dwarf's title in the message, assuming it'll reflect the new top skill. Or something like that.

I would've expected the message to reflect the newly attained skill level, i.e. "Legendary Carpenter".
Steps To Reproduce1. Assign some nobles.
2. Wait for one of them to have a skill-granting mood.
3. Satisfy the mood successfully.
4. Observe messages: "Urist McNoble, <noble> has created..." followed by "Urist McNoble has become a <noble>".

From 0004235:
1. Embark with a dwarf that has the most social skills and novice in all medical skills.
2. Give him the miner job with a pick.
3. Have him mine soil for a little bit.
4. Once his mining skill exceeds his medical skills the message will pop up.

From 0007708
1. Start with all dwarves completely unskilled.
2. Get the expedition leader to do stuff until they reach novice in something that warrants a title change.
Additional InformationSaves:
http://dffd.bay12games.com/file.php?id=12220 [^] (0.43.04)
Tags0.43.04
Relationships
has duplicate 0001891resolved Footkerchief Getting profession updates, but not changing titles 
has duplicate 0002251resolved Logical2u Chief Medical dwarf is assigned the post Chief Medical dwarf 
has duplicate 0002349resolved Footkerchief So & So has become a ______ 
has duplicate 0004235resolved lethosor Expedition leader X has become expedition leader 
has duplicate 0009885resolved lethosor Dwarf keeps becoming broker even though they were already a broker 
has duplicate 0007708resolved Knight Otu Expedition leader "has become a expedition leader" 
related to 0001482resolved Toady One Children that gain professional skills still grow up to be Peasants 
related to 0006357new  Adventurer title stops updating after the first "Legendary" weapon skill 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-06 17:28ImmoralFibreNew Issue
2010-05-06 17:51GReadNote Added: 0006319
2010-05-06 18:34FootkerchiefNote Added: 0006325
2010-05-06 18:35QuietustNote Added: 0006326
2010-05-06 18:35QuietustNote Deleted: 0006326
2010-05-16 00:27FootkerchiefRelationship addedparent of 0001891
2010-06-10 04:55Logical2uRelationship addedhas duplicate 0002251
2010-06-15 19:16FootkerchiefRelationship addedhas duplicate 0002349
2011-03-15 19:19FootkerchiefRelationship addedparent of 0004235
2011-04-03 03:03nb4estIssue Monitored: nb4est
2011-04-07 00:35nb4estIssue End Monitor: nb4est
2013-09-22 17:50FootkerchiefRelationship addedrelated to 0001482
2013-09-22 17:50FootkerchiefRelationship addedrelated to 0006357
2014-01-27 14:39FootkerchiefRelationship replacedhas duplicate 0001891
2014-01-27 14:39FootkerchiefIssue Monitored: thorvindr
2014-08-05 05:47lethosorAssigned To => lethosor
2014-08-05 05:47lethosorStatusnew => acknowledged
2015-03-07 12:17Afghani84Note Added: 0032340
2015-03-07 12:17Afghani84Issue Monitored: Afghani84
2016-07-04 16:17lethosorSummaryMood -> legendary carpenter, but reported as "has become a bookkeeper" => Noble profession change announcements always list nobles' current profession
2016-07-04 16:19lethosorSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14351#r14351
2016-07-04 16:20lethosorRelationship replacedhas duplicate 0004235
2016-07-04 16:20lethosorStatusacknowledged => confirmed
2016-07-04 16:20lethosorNote Added: 0035559
2016-07-04 16:21lethosorRelationship addedhas duplicate 0009885
2016-07-04 16:21lethosorRelationship addedhas duplicate 0007708
2016-07-04 16:22lethosorSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14352#r14352
2016-07-04 16:22lethosorAdditional Information Updatedbug_revision_view_page.php?rev_id=14354#r14354
2016-07-04 16:23lethosorTag Attached: 0.43.04

Notes
(0006319)
GRead   
2010-05-06 17:51   
This is actually even simpler to reproduce; just create a military. Now start assigning and canceling kill orders while the militia commander is off duty. Note how the announcement reads: "soandso has become a militia commander" when s/he goes on duty, and then "soandso has become a militia commander" when s/he goes off duty.
(0006325)
Footkerchief   
2010-05-06 18:34   
GRead: that's an old bug.

# 001029 □ [dwarf mode][interface][announcements] (http://www.bay12forums.com/smf/index.php?topic=25110.0 [^]) when entity appointee and related positions "X" change their base profession, it says "X has become an X"

I'm not sure it's exactly the same as the one in this report, but it's definitely related.
(0032340)
Afghani84   
2015-03-07 12:17   
I can confirm that this is still an issue in 40.23
(0035559)
lethosor   
2016-07-04 16:20   
Merged in 0004235 and friends.