Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002253Dwarf FortressDwarf Mode -- Tradepublic2010-06-10 05:532010-07-05 09:16
ReporterLangdon 
Assigned ToFootkerchief 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionduplicate 
PlatformOSOS Version
Product Version0.31.06 
Target VersionFixed in Version 
Summary0002253: Elven caravan is empty, has no items to trade
DescriptionIn a 7-year old fort (3.7m created wealth, 40k exported) the elven caravan suddenly fails to bring any items (trade screen is empty, and no foreign trade goods show up when using "T" on the trade depot) despite having two warthogs.

All elven caravans in previous years have arrived properly laden with reasonable amounts of trade goods, and I bought out all animals, wood and food items every year (except the first).

It's probably related to 0000325, possibly my caravan had gone over the "non-trade-capacity item cap" placed by Toady to fix that bug.

I will upload a save once I have managed to reproduce this bug in a new game.
Steps To Reproduce
Additional Information
Tagscaravan, trade depot, trading
Relationships
duplicate of 0000325resolved Toady One Elves bring hundreds/thousands of items when trading, due to warthogs lacking TRADE_CAPACITY tag 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-10 05:53LangdonNew Issue
2010-06-10 22:54LangdonNote Added: 0008119
2010-06-10 22:55LangdonTag Attached: trade depot
2010-06-10 22:55LangdonTag Attached: caravan
2010-06-10 22:56LangdonTag Attached: trading
2010-06-10 23:04FootkerchiefNote Added: 0008121
2010-06-11 02:21LangdonNote Added: 0008123
2010-06-11 05:51LangdonNote Added: 0008133
2010-06-11 06:50FootkerchiefNote Added: 0008137
2010-06-11 06:50FootkerchiefRelationship addedrelated to 0000325
2010-06-12 12:21SpacemanSpiffNote Added: 0008207
2010-06-12 22:21GeocatIssue Monitored: Geocat
2010-06-18 08:55UltraviolentNote Added: 0008627
2010-06-18 09:02UltraviolentNote Deleted: 0008627
2010-07-05 09:16FootkerchiefRelationship replacedduplicate of 0000325
2010-07-05 09:16FootkerchiefStatusnew => resolved
2010-07-05 09:16FootkerchiefResolutionopen => duplicate
2010-07-05 09:16FootkerchiefAssigned To => Footkerchief

Notes
(0008119)
Langdon   
2010-06-10 22:54   
Next year the elves returned with five warthogs, again all empty. What's weird is that the "allowed weight" on the trade screen is only about 70 dwarfpounds or so, despite not carrying any goods. (I "o"ffered some of my trade goods to see if that would make anything show up, and was limited by the allowed weight). I checked the trade depot again with "T" to see if there were any "invisible" trade goods that merely did not show up on the trade interface, but there were no goods other than the ones I had hauled myself to the depot (no wooden goods at all).
(0008121)
Footkerchief   
2010-06-10 23:04   
You transferred this save from an older version, right? The problem is probably that your elven civ is still using warthogs as their trade animals, but the new trade capacity default prevents them from actually carrying anything. Try copying the 31.06 raws over your save raws and seeing whether that changes anything. (you may want to backup your save first)
(0008123)
Langdon   
2010-06-11 02:21   
The game was genned on 31.05, but I remember I overwrote the raws with the .06 version in both the main raw/objects and save/region1/raw/objects directories.

To verify, I took a seasonal save from the start of spring and overwrote the raws in that directory with a fresh copy from the .06 zip. The elves arrived, again with seven warthogs and no trade goods.

I guess this save is broken as far as elves are concerned. I'll start a new game on .06 later and update this page if this problem reappears.
(0008133)
Langdon   
2010-06-11 05:51   
Ok, fiddling around a bit with Phoebus's graphics set in a different game, I found a workaround.

Adding [COMMON_DOMESTIC][PACK_ANIMAL] back under the warthog entry in creature_large_tropical.txt allowed warthogs to carry items once again, and the elven caravan arrived with trade goods. I guess once an entity civ generates its usable pack animals, it will not change if the raws are changed mid-game.

This should only be needed for 31.05 games transferred to 31.06 - I guess fresh 31.06 games should have these tags deleted to remove warthogs from the list of allowable pack animals as Toady intended.
(0008137)
Footkerchief   
2010-06-11 06:50   
I guess once an entity civ generates its usable pack animals, it will not change if the raws are changed mid-game.

That seems likely. Good work investigating that -- it might be handy for modders too.

This should only be needed for 31.05 games transferred to 31.06 - I guess fresh 31.06 games should have these tags deleted to remove warthogs from the list of allowable pack animals as Toady intended.

Hopefully, yeah. I'll post a note on 0000325 alerting people to this problem.
(0008207)
SpacemanSpiff   
2010-06-12 12:21   
I've hit the same issue in a game that was started in 31.05 and then transferred over to 31.06. Two elven caravans in a row have arrived with lots of warthogs and no trade goods. Thankfully this bug was the first one I looked at when I did a search on "caravans" :) I'll use Langdon's workaround