Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002924Dwarf FortressDwarf Mode -- Moodspublic2010-08-01 21:152014-01-27 13:33
ReporterChthon 
Assigned To 
PrioritylowSeveritytweakReproducibilityhave not tried
StatusnewResolutionopen 
PlatformPCOSWindows 7OS VersionPro 64bit
Product Version0.31.12 
Target VersionFixed in Version 
Summary0002924: Moody dwarf has inconsistent display of quantities for primary vs. decorative items
DescriptionIn the past, if a dwarf needed more than one of an item/stack he would spend more time requesting it on the workshop orders screen. This time the following happened:
For 2 seconds drew pictures of skeletons.
For 2 seconds drew pictures of square blocks.
For 2 seconds drew pictures of stacked cloth.
For 2 seconds drew pictures of stacked leather.
Repeat.

Then he insisted on picking up in order: 3 stacks of bones, 1 rock block, 1 bolt of cloth, and one piece of leather.

Is this normal in the new version, or was this a bug?
Steps To Reproduce
Additional InformationIf this is how it will work in the future might I suggest that once a moody dwarf has all of a type of item he needs he stop requesting it. That and grab everything he can and only stop when there's nothing else available that he wants. This would make it much easier to work with strange moods than it currently is. After all it makes no sense to keep having him scream "I must have shells" if he's already gotten one and only wanted one.
TagsNo tags attached.
Relationships
related to 0002806resolved Toady One Bone Artifacts Missing Decorations and Materials 
related to 0000159resolved Footkerchief Mood failed because dwarf cannot find needed material 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-01 21:15ChthonNew Issue
2010-08-01 21:34ChthonNote Added: 0011384
2010-08-01 22:03FootkerchiefNote Added: 0011389
2010-08-01 22:03FootkerchiefRelationship addedrelated to 0002806
2010-08-01 22:43ChthonNote Added: 0011392
2010-08-02 04:17ChthonNote Added: 0011395
2010-08-02 05:32Logical2uNote Added: 0011397
2010-08-02 05:48ChthonNote Edited: 0011395bug_revision_view_page.php?bugnote_id=0011395#r4459
2010-08-02 05:49ChthonNote Added: 0011398
2010-08-02 20:18ChthonNote Edited: 0011398bug_revision_view_page.php?bugnote_id=0011398#r4474
2010-08-03 15:16ChthonNote Edited: 0011398bug_revision_view_page.php?bugnote_id=0011398#r4483
2010-08-05 07:02ChthonNote Added: 0011520
2010-08-05 07:06ChthonNote Edited: 0011520bug_revision_view_page.php?bugnote_id=0011520#r4499
2010-08-05 07:08ChthonNote Edited: 0011520bug_revision_view_page.php?bugnote_id=0011520#r4500
2010-08-05 11:06kwielandNote Added: 0011524
2010-08-06 03:50ChthonNote Added: 0011544
2010-08-06 07:48kwielandNote Edited: 0011524bug_revision_view_page.php?bugnote_id=0011524#r4513
2010-08-07 03:06ChthonNote Added: 0011585
2010-08-07 04:46ChthonNote Edited: 0011585bug_revision_view_page.php?bugnote_id=0011585#r4525
2010-09-14 07:00QuietustNote Added: 0012629
2011-06-01 13:07king doomNote Added: 0017916
2011-06-01 13:59QuietustNote Added: 0017917
2011-06-04 14:53PutIssue Monitored: Put
2014-01-27 13:33FootkerchiefSummaryDwarf requires 3 stacks of bone even though he only drew one picture of skeletons => Moody dwarf has inconsistent display of quantities for primary vs. decorative items
2014-01-27 13:36FootkerchiefRelationship addedrelated to 0000159

Notes
(0011384)
Chthon   
2010-08-01 21:34   
Resulting artifact was wierd.
"This is a donkey bone table. All craftmanship is of the highest quality."
Thats it. No modifiers at all. 1200 Dwarfbucks too.

In my experience all artifacts have 1 modifier per input material, with a minimum of one modifier ever. This one had 7 input materials and 0 modifiers.
(0011389)
Footkerchief   
2010-08-01 22:03   
The lack of modifiers is 0002806.
(0011392)
Chthon   
2010-08-01 22:43   
Well if anything you have some info as to how this may have come about. Symptoms include requiring additional stacks of items that were not originally requested.
(0011395)
Chthon   
2010-08-02 04:17   
(edited on: 2010-08-02 05:48)
Update: I can now reproduce this error. Or at the least it has been reproduced.

Like last time this was a bone carver mood. It only listed that it needed one stack of bones, but instead required three before it would proceed. Resulting artifact did not have any properties except for the base materials. I have saves from after the previous bugged artifact and during and after the second bugged artifact. Uploading them to DFFD now.

Files uploaded in one zip: http://dffd.wimbli.com/file.php?id=2881 [^]
(0011397)
Logical2u   
2010-08-02 05:32   
Chthon, if the dwarf only requests one type of item, it can be difficult to identify the number of items they require as there is often no break between the displays items.

Essentially, "Needs bones" looks exactly the same as "Needs bones" and "Needs bones" back to back. So I'm not sure this is a bug beyond a duplicate of 0002806.
(0011398)
Chthon   
2010-08-02 05:49   
(edited on: 2010-08-03 15:16)
Check out the saves. Usually if they need 3 of an item it will display the need bones for 3 times as long. In this save he does not display it for 3 times as long. If you actually take a stopwatch to it it is the same length for all items.

To put it another way, needs bone needs bones does not look exactly like needs bones. It looks instead like Neeeeds Boooones. Here I should have seen something like that but if you check the save out you do not.

Update: Carpenter mood requiring bones had no issues of needing extra stacks of bones. This may just be a bone carver issue. Waiting to see a mood which legitimately requires 2 or more of an item in a row to show a save with the delay difference.
(0011520)
Chthon   
2010-08-05 07:02   
(edited on: 2010-08-05 07:08)
Just had a woodworker require 1 Time unit logs, 1 time unit bones. He took 2 logs and 1 stack of bones. Will update with whether or not he creates a bugged artifact here.

Update: Was not bugged. Still the only moods that fail to produce correct artifacts for the inputs are bone crafter moods.

Also Logical2U, just noticed that you failed to notice that both of the bugged artifacts required more than just bones to create. Both required 6+ ingredients and 2 extra bones that were not listed. One was 8 items before the 2 extra bone stacks.
(0011524)
kwieland   
2010-08-05 11:06   
(edited on: 2010-08-06 07:48)
I also have observed this bug but I don't have the save. In 40d, as Chthon said, the time (or if it was repeated in different places) was significant. .31 doesn't seem to have that. I have seen dwarfs only use one thing to make an artifact, which I wouldn't think would have a modifier. The fact that they got several items and they were not incorporated into the artifact is bizarre and definitely a bug.

EDIT: Same thing again - requested "bones". Took three, and the finished artifact was only "a rhesus bone gauntlet" Nothing about the donkey and dog bones.
(0011544)
Chthon   
2010-08-06 03:50   
Just had a stonecrafter mood require 1 TU stone, 1 TU cloth. He took 3 stone and 1 cloth and made a correct artifact.
(0011585)
Chthon   
2010-08-07 03:06   
(edited on: 2010-08-07 04:46)
Just had a jewelcrafter require 1 TU cloth, 1 TU cut gems, 1 TU logs. He took 2 cloth 1 cut gems and 1 log.

It's looking more and more that moods require 2 of the base item type and one or more of everything else. The bug then would be that bonecrafter moods instead require 3 stacks of bones and get bugged as a result.

Edit: Looks like I had a bonecarver mood where he only required 2 stacks of bones. Still got a bugged artifact though. Perhaps total of the stacks has to be 30 bones? Will have to test this more.
(0012629)
Quietust   
2010-09-14 07:00   
The mechanics of mood item requirements seems to have changed, presumably as a result of object dimensions for stuff like bars, cloth, and thread - when the dwarf gets a mood, the job itself only has one entry for the primary material and it uses the "quantity" to determine how much it needs, just like how making rose gold requires "3 bars of gold, 1 bar of copper" (technically 450 and 150) rather than "1 bar of gold, 1 bar of gold, 1 bar of gold, 1 bar of copper"; as a result, the first ingredient only shows up for the 2 seconds indicative of a single ingredient. Subsequent ingredients will show up multiple times just as they have in the past.
(0017916)
king doom   
2011-06-01 13:07   
This might be intended behaviour, checking this involves timing how long the message for each requirement is onscreen before it changes. It could be the game is flashing up 'needs x' for three seconds, then flashing up the next requirement, which is also 'needs x', so it seems like it needs only one item instead of two or three.
(0017917)
Quietust   
2011-06-01 13:59   
king doom: read the original bug report again - it's clearly stated that the "pictures of skeletons" was only shown for 2 seconds, not the 6 seconds he was expecting.