Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005948Dwarf FortressDwarf Mode -- Jobs, Haulingpublic2012-05-24 11:302012-05-27 18:24
Reporterag 
Assigned ToToady One 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.34.10 
Target VersionFixed in Version0.34.11 
Summary0005948: Detaching container from a Store In Bin/Barrel job causes crash in combining code.
DescriptionWhen the target container used in a new-style batch Store In Bin/Barrel job is removed, it causes a crash in the code used to detect if an item can be combined into an already existing job.
Steps To ReproduceEnsure there are many pending items to store that suddenly get the opportunity; wait until a suitable combined job is in progress, and forbid the container. As soon as the code tries to stockpile another item, it will crash.
Additional InformationWhen the container is forbidden, it is immediately removed from the job; but the job itself only gets a flag set, and would be cancelled at a later point. Meanwhile, the loop that searches for a suitable job to combine into does not check this flag, and assumes there always is a container item attached. When it fails to find an item reference of type 2, it crashes trying to access a NULL pointer.

This explains the crash mentioned in bug 0005937.
TagsNo tags attached.
Relationships
related to 0005937resolved Toady One Hauler with bin wanders in circles 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-24 11:30agNew Issue
2012-05-24 12:00FootkerchiefNote Added: 0022704
2012-05-24 12:00FootkerchiefNote Added: 0022705
2012-05-24 12:00FootkerchiefRelationship addedduplicate of 0005937
2012-05-24 12:00FootkerchiefStatusnew => resolved
2012-05-24 12:00FootkerchiefResolutionopen => duplicate
2012-05-24 12:00FootkerchiefAssigned To => Footkerchief
2012-05-24 12:00FootkerchiefNote Deleted: 0022704
2012-05-24 14:47FootkerchiefAssigned ToFootkerchief =>
2012-05-24 14:47FootkerchiefStatusresolved => new
2012-05-24 15:11FootkerchiefRelationship replacedrelated to 0005937
2012-05-27 18:19Toady OneStatusnew => resolved
2012-05-27 18:19Toady OneFixed in Version => Next Version
2012-05-27 18:19Toady OneAssigned To => Toady One
2012-05-27 18:24Toady OneStatusresolved => assigned
2012-05-27 18:24Toady OneStatusassigned => resolved
2012-05-27 18:24Toady OneResolutionduplicate => fixed

Notes
(0022705)
Footkerchief   
2012-05-24 12:00   
Unless I'm misunderstanding something, this is a duplicate of 0005937. If you find information that explains an existing report, it's more helpful to post that information at the existing report than to create a new report.