0005283: Crash upon accepting/saving a generated world when old-version saves are present

Notes
(0020096) brcruchairman (reporter) 2012-02-19 00:00 edited on: 2012-02-19 00:23	Just tried this again in an Einsteinian Insane fashion; apparently, this bug exists on the SDL download, but not the Legacy download. That is, attempting the exact same steps on a Legacy download works normally, no crash, but on an SDL download, I couldn't avoid the crash. Not sure what this means, but I figure it'll be dismissed if it was just user error. ---Edit 2/19/2012--- After messing around with this some more, I discovered that it has less to do with an SDL versus Legacy download so much as the directory the install was put in. Both the SDL and Legacy downloads, when put in my old DF directory of C:\Dwarf Fortress, would not run. However, both of the same downloads when put in my download folder (e.g., C:\Users\Andrew W\Downloads\df_34_02_win) would work. Perhaps this has more to do with the directory than the version?

(0020123) Footkerchief (manager) 2012-02-19 08:06	Can you confirm that it has anything to do with whether the map has been scrolled around?

(0020413) brcruchairman (reporter) 2012-02-21 14:09	Yes, I can confirm that it's independent of map scrolling; pressing enter immediately upon the completion of the world results in the same error, given that it's in a C:\Dwarf Fortress directory. Scrolling when playing on the game located in my download directory, scrolling did not interfere with the saving of the world; I can play just fine in that directory, just not at all in the C:\Dwarf Fortress one. Now I wish I could figure out how to change the bug report's urgency from “urgent” to “minor” when the workaround is so easy, and problem is so specific.

(0020473) Xotano (reporter) 2012-02-22 11:05	strange i don't seem to have that problem. but i did have a different one that went with aborting world gen early, wasn't really a crash tho.

(0021030) Logical2u (manager) 2012-03-03 13:13	brcruchairman, can you see if this is a problem due to DF running out of memory with your SDL download? The specific error message you reported has been around for a long time and I suspect that memory usage is to blame.

(0022364) brcruchairman (reporter) 2012-04-24 01:40	I can try; how would I go about doing that? Is there some program I'd run, or some setting I'd change?

(0022369) marq (reporter) 2012-04-24 09:51	Additional info: I tried to convert some saves from 0.31.25 When DF failed to recognize them, I went ahead and tried to generate a new world, without removing the old files from the save directory. Same error, crashes on accept. Did this several times with a clean install. Removed the save files, tried again, bug averted.

(0022496) Solarius Scorch (reporter) 2012-05-14 13:18	I confirm marq's case: after removing old worlds from the previous versions, the bug no longer occurred.

(0022898) brcruchairman (reporter) 2012-06-07 20:15	Well, one way or another, this bug is gone as of 0.34.11; I downloaded the newest version, put it in my C:\Dwarf Fortress directory, generated a new world on totally standard settings, and it saved just fine. Tried again with a pocket dimension, very short history and the same thing. Whatever it was, the issue appears to be fixed.

(0023167) velusip (reporter) 2012-07-05 20:17	Are you sure this isn't some sort of permissions issue? e.g. I was getting this same problem with Linux version 0.34.11 until I cleared the "current" and "region1" directories out of my saves with incorrect permissions: /opt/df_linux/data/save Depending on your distribution/installation method your saves might be stowed elsewhere.

(0025822) darklord92 (reporter) 2014-07-11 12:15	Can confirm permissions issue as above, clearing out the saves directory fixed it for me.

(0026276) blockplanner (reporter) 2014-07-13 21:52	Issue seems to be present in the latest version. Clearing out an old save fixed the crash on an otherwise brand new extracted windows SDL 0.40.03

(0026318) dree12 (reporter) 2014-07-14 07:20 edited on: 2014-07-14 07:22	I ran across this issue recently and have diagnosed its cause. Basically, the game does not delete files from the old world when overwriting it with the new world's files. This means there are many files that are not related to the new world. One way to fix it is to sort the files by "last modified" date and delete the files that were last modified before the rest, as they are leftover files from the old world. There is no other corruption aside from that. When the two versions are very similar but still incompatible, like in 0007230 between 0.40.02 and 0.40.03, there is the additional twist that often the world will save properly. Some actions are even possible without immediate crashing, such as running the calendar before playing.

Issue History
Date Modified	Username	Field	Change
2012-02-18 18:21	brcruchairman	New Issue
2012-02-18 23:57	brcruchairman	Issue Monitored: brcruchairman
2012-02-19 00:00	brcruchairman	Note Added: 0020096
2012-02-19 00:23	brcruchairman	Note Edited: 0020096	View Revisions
2012-02-19 08:06	Footkerchief	Note Added: 0020123
2012-02-19 08:06	Footkerchief	Tag Attached: AWAITING UPDATE
2012-02-19 11:07	Logical2u	Relationship added	related to 0005303
2012-02-21 14:09	brcruchairman	Note Added: 0020413
2012-02-22 09:04	Footkerchief	Relationship replaced	has duplicate 0005303
2012-02-22 09:04	Footkerchief	Relationship added	related to 0005053
2012-02-22 09:05	Footkerchief	Summary	Saving a generated world crashes dwarf fortress => Accepting/saving a generated world crashes dwarf fortress
2012-02-22 09:06	Footkerchief	Relationship added	has duplicate 0005395
2012-02-22 09:06	Footkerchief	Summary	Accepting/saving a generated world crashes dwarf fortress => Crash upon accepting/saving a generated world
2012-02-22 11:05	Xotano	Note Added: 0020473
2012-02-29 20:19	Footkerchief	Relationship added	has duplicate 0005515
2012-03-01 19:55	Logical2u	Relationship added	has duplicate 0005525
2012-03-03 13:13	Logical2u	Note Added: 0021030
2012-03-12 12:19	Footkerchief	Relationship added	related to 0000136
2012-04-24 01:40	brcruchairman	Note Added: 0022364
2012-04-24 09:51	marq	Note Added: 0022369
2012-05-14 08:58	Footkerchief	Relationship added	has duplicate 0005861
2012-05-14 13:18	Solarius Scorch	Note Added: 0022496
2012-05-14 15:53	Footkerchief	Summary	Crash upon accepting/saving a generated world => Crash upon accepting/saving a generated world when old-version saves are present
2012-05-17 10:57	Footkerchief	Issue Monitored: Toady One
2012-06-04 06:29	Footkerchief	Relationship added	related to 0005978
2012-06-06 13:33	Footkerchief	Relationship added	related to 0005161
2012-06-06 13:34	Footkerchief	Relationship deleted	related to 0005161
2012-06-07 20:15	brcruchairman	Note Added: 0022898
2012-07-05 20:17	velusip	Note Added: 0023167
2014-01-20 19:42	Footkerchief	Relationship replaced	has duplicate 0005978
2014-01-26 08:44	Footkerchief	Relationship replaced	has duplicate 0005053
2014-01-26 08:44	Footkerchief	Issue Monitored: lightman
2014-01-26 08:44	Footkerchief	Issue Monitored: Symmetry
2014-01-26 08:44	Footkerchief	Issue Monitored: wRAR
2014-01-26 08:44	Footkerchief	Issue Monitored: hyperactiveChipmunk
2014-01-26 08:44	Footkerchief	Issue Monitored: tasteful
2014-01-26 08:44	Footkerchief	Issue Monitored: rmric0
2014-01-26 08:44	Footkerchief	Issue Monitored: nCrazed
2014-07-09 18:52	lightman	Issue End Monitor: lightman
2014-07-11 07:27	Footkerchief	Relationship added	related to 0005238
2014-07-11 07:28	Footkerchief	Relationship deleted	related to 0005238
2014-07-11 07:28	Footkerchief	Relationship added	related to 0007018
2014-07-11 07:28	Footkerchief	Relationship added	child of 0006780
2014-07-11 07:28	Footkerchief	Relationship replaced	related to 0006780
2014-07-11 07:29	Footkerchief	Relationship deleted	related to 0006780
2014-07-11 07:29	Footkerchief	Relationship added	related to 0006806
2014-07-11 07:30	Footkerchief	Relationship replaced	has duplicate 0007018
2014-07-11 07:30	Footkerchief	Relationship added	has duplicate 0007034
2014-07-11 08:12	Footkerchief	Tag Detached: AWAITING UPDATE
2014-07-11 12:15	darklord92	Note Added: 0025822
2014-07-13 21:52	blockplanner	Note Added: 0026276
2014-07-13 23:51	Footkerchief	Relationship added	has duplicate 0007230
2014-07-13 23:51	Footkerchief	Relationship added	has duplicate 0007252
2014-07-13 23:51	Footkerchief	Relationship added	related to 0003968
2014-07-14 07:20	dree12	Note Added: 0026318
2014-07-14 07:20	dree12	Note Edited: 0026318	View Revisions
2014-07-14 07:22	dree12	Note Edited: 0026318	View Revisions
2014-07-14 10:29	Toady One	Status	new => resolved
2014-07-14 10:29	Toady One	Fixed in Version	=> Next Version
2014-07-14 10:29	Toady One	Resolution	open => fixed
2014-07-14 10:29	Toady One	Assigned To	=> Toady One
2014-07-18 22:42	Footkerchief	Relationship added	has duplicate 0007470