0000073: cannot disable the use of obsidian in the z->stone screen

(0000070)
DoctorZuber (reporter)
2010-04-01 19:12

a careful inspection of z / stones reveals that obsidian is not even listed.

(0000145)
aepurniet (reporter)
2010-04-02 01:39

thats right. i manually forbid all of it from the z->stocks screen. easy enough work around, but it would be nice if it worked (as i imagine) as it was intended.

(0000629)
Shurhaian (reporter)
2010-04-03 12:52

Probably related to 0000256. Obsidian is not being used to make "rock swords", thus it's not an economic stone, thus it isn't in the Stones screen.

(0002021)
mattspierce (reporter)
2010-04-08 07:18

I was trying to enable obsidian and couldn't mark it as a non economic stone. I noticed that Raw Adamantine has the property Sharp blades. It looks like obsidian and Raw adamantine have gotten squashed together somehow.

(0002024)
Jimmy (reporter)
2010-04-08 07:35
edited on: 2010-04-08 07:41

Actually most ores now have the ability to make sharp blades.
And yes, obsidian is not listed in the Stones menu. Possibly related to [LAVA] tag? Removing the tag from a previous save doesn't make it show up, so probably not, but that's about all I can see from the raw files that makes it different to other stones, bar the value.

(0003812)
caranha (reporter)
2010-04-16 00:44

I have found out that this is related to the [MAX EDGE] tag. Removing the [MAX EDGE] from obsidian makes it show up in the economic stone menu again. It also makes it no longer able to make swords (as expected)

By the same token, adding a [MAX EDGE] tag to another stone with a very high value makes it able to make swords (as expected) and removes it from the economic menu (try it with a normal, useless stone).

ON THE OTHER HAND, if you take a MAX EDGE stone, and add the [FLUX] tag to it, it starts to appear again on the menu. (and becomes flux material).

My guess is that the logic that hides/shows things in the economic menu is inversed for "sharp blade" stones. So all the common stones which are NOT able to be sharp blades appear on the menu, and obsidian, which is "sharp blade"-able and nothing else gets hidden.

Workaround:
Even if the stone is not being displayed on the economics menu, its green/red status is remembered by the game. So if you want to use obsidian for constructions, you can remove the "max edge" tag from obsidian in the raws (material_stone_layer.txt), load your game - obsidian will be shown as red in your economic stone menu. Turn it to green. Then save your game, and return the "max edge" tag to obsidian. When you return to your game, you won't be able to see obsidian anymore, but the game will remember that you gave permission for the use of obsidian.

(0007661)
aepurniet (reporter)
2010-06-04 11:05

awesome workaround!

(0017148)
Footkerchief (manager)
2011-04-06 17:18

Reminder sent to: aepurniet, caranha, DoctorZuber, Shurhaian

Is this bug still present in 0.31.25, or was it fixed along with related bug 0000256?

(0017164)
kwieland (reporter)
2011-04-07 10:34

Obsidian is still not shown on the economics "stone" menu. v.25

(0017204)
king doom (reporter)
2011-04-08 10:49

I got this bug in the newest version (31.25)

(0017213)
wedgebert (reporter)
2011-04-08 15:25

There's another work around that doesn't require either removing the max_edge permenantly or save/loading each time you want to toggle its status.

Create a custom reaction of some sort that uses obsidian as a reagent and that seems to make it appear normally.

For example, I have:
[REACTION:MAKE_OBSIDIAN_MECHANISMS]
[NAME:make obsidian mechanism]
[BUILDING:ADVANCED_MECHANICS:NONE]
[REAGENT:A:1:BOULDER:NONE:INORGANIC:OBSIDIAN]
[PRODUCT:100:1:TRAPPARTS:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
[SKILL:MECHANICS]
And every thing works fine

(0018919)
Quietust (reporter)
2011-10-27 13:24
edited on: 2011-10-27 13:29

The Stones screen appears to exclude all inorganic materials whose only "special" characteristic is "Sharp blades", i.e. having MAX_EDGE >= 10000.

The following binary patch disables this check in Win32 v0.31.25 SDL:
0x2AD5F4: 33 -> 00

As a side effect, this causes all other metals to start showing up in the list.

Alternatively, the following binary patch switches the condition around (from "MAX_EDGE >= 10000" to "MAX_EDGE < 10000") and causes the Stone screen to exclude materials which cannot be used for "Sharp blades" (or anything else), effectively making the Stones screen behave the same way as it did back in 40d (and not listing "mundane" stones), which is probably how it was supposed to work all along:
0x2AD5F3: 7D -> 7C

(0019451)
Quietust (reporter)
2012-02-01 11:40

Binary patch for version 0.31.25 Linux: (untested)
4A7F52 : C5 FB FF FF -> 00 00 00 00 (display all stones)
or
4A7F51 : 8F -> 8E (show obsidian but hide all "mundane" stones)

(0019867)
Toady One (administrator)
2012-02-16 16:50

This should be sorted now. Thanks Quietust!

Issue History
Date Modified	Username	Field	Change
2010-04-01 19:06	aepurniet	New Issue
2010-04-01 19:12	DoctorZuber	Note Added: 0000070
2010-04-02 01:39	aepurniet	Note Added: 0000145
2010-04-02 06:27	Todestool	Tag Attached: stone screen
2010-04-03 12:52	Shurhaian	Note Added: 0000629
2010-04-08 07:18	mattspierce	Note Added: 0002021
2010-04-08 07:35	Jimmy	Note Added: 0002024
2010-04-08 07:41	Jimmy	Note Edited: 0002024	View Revisions
2010-04-16 00:44	caranha	Note Added: 0003812
2010-04-16 02:37	caranha	Issue Monitored: caranha
2010-04-20 21:36	Magish	Issue Monitored: Magish
2010-04-29 13:16	Footkerchief	Category	General => Dwarf Mode -- Interface, Status
2010-05-03 21:30	Footkerchief	Relationship added	parent of 0001729
2010-06-04 11:05	aepurniet	Note Added: 0007661
2010-06-05 15:11	CultOftheRaven	Issue Monitored: CultOftheRaven
2010-07-26 15:09	tieren	Issue Monitored: tieren
2010-10-11 13:23	kwieland	Issue Monitored: kwieland
2011-03-21 06:15	Logical2u	Relationship added	has duplicate 0004266
2011-04-06 17:14	Footkerchief	Relationship replaced	has duplicate 0001729
2011-04-06 17:15	Footkerchief	Relationship added	has duplicate 0003171
2011-04-06 17:16	Footkerchief	Relationship added	related to 0000256
2011-04-06 17:18	Footkerchief	Issue Monitored: DoctorZuber
2011-04-06 17:18	Footkerchief	Issue Monitored: Shurhaian
2011-04-06 17:18	Footkerchief	Note Added: 0017148
2011-04-06 17:18	Footkerchief	Tag Attached: AWAITING UPDATE
2011-04-07 10:34	kwieland	Note Added: 0017164
2011-04-08 10:49	king doom	Note Added: 0017204
2011-04-08 15:25	wedgebert	Note Added: 0017213
2011-04-09 09:24	wedgebert	Issue Monitored: wedgebert
2011-10-27 13:24	Quietust	Note Added: 0018919
2011-10-27 13:29	Quietust	Note Edited: 0018919	View Revisions
2011-10-27 13:29	Quietust	Note Edited: 0018919	View Revisions
2011-10-27 22:39	Kogut	Tag Attached: binary patch
2012-02-01 11:40	Quietust	Note Added: 0019451
2012-02-16 16:50	Toady One	Note Added: 0019867
2012-02-16 16:50	Toady One	Assigned To	=> Toady One
2012-02-16 16:50	Toady One	Status	new => needs feedback
2012-02-16 16:50	Toady One	Status	needs feedback => resolved
2012-02-16 16:50	Toady One	Fixed in Version	=> Next Version
2012-02-16 16:50	Toady One	Resolution	open => fixed
2012-02-17 13:18	kwieland	Issue End Monitor: kwieland
2012-02-18 08:10	wedgebert	Issue End Monitor: wedgebert
2012-03-05 15:51	Logical2u	Tag Detached: AWAITING UPDATE
2014-01-15 14:49	Kirig Stonebeard II	Issue Monitored: Kirig Stonebeard II
2014-01-17 10:03	Kirig Stonebeard	Issue Monitored: Kirig Stonebeard

Notes
(0000070) DoctorZuber (reporter) 2010-04-01 19:12	a careful inspection of z / stones reveals that obsidian is not even listed.

(0000145) aepurniet (reporter) 2010-04-02 01:39	thats right. i manually forbid all of it from the z->stocks screen. easy enough work around, but it would be nice if it worked (as i imagine) as it was intended.

(0000629) Shurhaian (reporter) 2010-04-03 12:52	Probably related to 0000256. Obsidian is not being used to make "rock swords", thus it's not an economic stone, thus it isn't in the Stones screen.

(0002021) mattspierce (reporter) 2010-04-08 07:18	I was trying to enable obsidian and couldn't mark it as a non economic stone. I noticed that Raw Adamantine has the property Sharp blades. It looks like obsidian and Raw adamantine have gotten squashed together somehow.

(0002024) Jimmy (reporter) 2010-04-08 07:35 edited on: 2010-04-08 07:41	Actually most ores now have the ability to make sharp blades. And yes, obsidian is not listed in the Stones menu. Possibly related to [LAVA] tag? Removing the tag from a previous save doesn't make it show up, so probably not, but that's about all I can see from the raw files that makes it different to other stones, bar the value.

(0003812) caranha (reporter) 2010-04-16 00:44	I have found out that this is related to the [MAX EDGE] tag. Removing the [MAX EDGE] from obsidian makes it show up in the economic stone menu again. It also makes it no longer able to make swords (as expected) By the same token, adding a [MAX EDGE] tag to another stone with a very high value makes it able to make swords (as expected) and removes it from the economic menu (try it with a normal, useless stone). ON THE OTHER HAND, if you take a MAX EDGE stone, and add the [FLUX] tag to it, it starts to appear again on the menu. (and becomes flux material). My guess is that the logic that hides/shows things in the economic menu is inversed for "sharp blade" stones. So all the common stones which are NOT able to be sharp blades appear on the menu, and obsidian, which is "sharp blade"-able and nothing else gets hidden. Workaround: Even if the stone is not being displayed on the economics menu, its green/red status is remembered by the game. So if you want to use obsidian for constructions, you can remove the "max edge" tag from obsidian in the raws (material_stone_layer.txt), load your game - obsidian will be shown as red in your economic stone menu. Turn it to green. Then save your game, and return the "max edge" tag to obsidian. When you return to your game, you won't be able to see obsidian anymore, but the game will remember that you gave permission for the use of obsidian.

(0007661) aepurniet (reporter) 2010-06-04 11:05	awesome workaround!

(0017148) Footkerchief (manager) 2011-04-06 17:18	Reminder sent to: aepurniet, caranha, DoctorZuber, Shurhaian Is this bug still present in 0.31.25, or was it fixed along with related bug 0000256?

(0017164) kwieland (reporter) 2011-04-07 10:34	Obsidian is still not shown on the economics "stone" menu. v.25

(0017204) king doom (reporter) 2011-04-08 10:49	I got this bug in the newest version (31.25)

(0017213) wedgebert (reporter) 2011-04-08 15:25	There's another work around that doesn't require either removing the max_edge permenantly or save/loading each time you want to toggle its status. Create a custom reaction of some sort that uses obsidian as a reagent and that seems to make it appear normally. For example, I have: [REACTION:MAKE_OBSIDIAN_MECHANISMS] [NAME:make obsidian mechanism] [BUILDING:ADVANCED_MECHANICS:NONE] [REAGENT:A:1:BOULDER:NONE:INORGANIC:OBSIDIAN] [PRODUCT:100:1:TRAPPARTS:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE] [SKILL:MECHANICS] And every thing works fine

(0018919) Quietust (reporter) 2011-10-27 13:24 edited on: 2011-10-27 13:29	The Stones screen appears to exclude all inorganic materials whose only "special" characteristic is "Sharp blades", i.e. having MAX_EDGE >= 10000. The following binary patch disables this check in Win32 v0.31.25 SDL: 0x2AD5F4: 33 -> 00 As a side effect, this causes all other metals to start showing up in the list. Alternatively, the following binary patch switches the condition around (from "MAX_EDGE >= 10000" to "MAX_EDGE < 10000") and causes the Stone screen to exclude materials which cannot be used for "Sharp blades" (or anything else), effectively making the Stones screen behave the same way as it did back in 40d (and not listing "mundane" stones), which is probably how it was supposed to work all along: 0x2AD5F3: 7D -> 7C

(0019451) Quietust (reporter) 2012-02-01 11:40	Binary patch for version 0.31.25 Linux: (untested) 4A7F52 : C5 FB FF FF -> 00 00 00 00 (display all stones) or 4A7F51 : 8F -> 8E (show obsidian but hide all "mundane" stones)

(0019867) Toady One (administrator) 2012-02-16 16:50	This should be sorted now. Thanks Quietust!