0000801: Forges don't care if bars have a small PRODUCT_DIMENSION

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000801

Dwarf Fortress

Dwarf Mode -- Buildings, General

public

2010-04-08 09:15

2014-01-27 08:10

Reporter

uprightpath

Assigned To

Toady One

Priority

normal

Severity

major

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

0.31.01

Target Version

Fixed in Version

Summary

0000801: Forges don't care if bars have a small PRODUCT_DIMENSION

Description

On a reaction product [PRODUCT_DIMENSION:X] seems to be used to set how 'large' the item is, in terms of 'volume' in the case of bars and powders, 'strand count' in threads, and thread count in cloth. However, forges do not seem to take into account the [PRODUCT_DIMENSION:X] of bars. A bar of X = 10 works as well as a bar of X = 150.

Also, in a reaction if you have an item with [PRODUCT_DIMENSION:150] and a reaction like...
[REAGENT:A:30:BAR:NONE:METAL:NONE]
... The product will have 5 chances to be made automatically. For each [PRODUCT_DIMENSION:X] with a [REAGENT:A:Y:BAR:NONE:METAL:NONE] the product(s) will have their chance to be created X % Y times.

Steps To Reproduce

Create a custom reaction with:
[PRODUCT:100:1:BAR:NONE:METAL:IRON][PRODUCT_DIMENSION:50]

and another with

[REAGENT:A:10:BAR:NONE:METAL:IRON]
[PRODUCT:100:3:TOY:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]

A bar made with the first custom reaction can be used at a forge with no problem, even though it's only 1/3 the size of normal bars that come from a smelter, using the METAL_ORE value of it.

If a bar made with the first reaction is then used with the second, the result is that there are 15 TOYs of various subtypes in the shop, instead of just 1.

Tags

custom buildings, forge, Intentional/Expected?, reactions, reagents

Attached Files

Relationships

related to	0000130	resolved	Toady One	Forge jobs always use only a single bar
related to	0006420	acknowledged	Footkerchief	Strange mood requests don't take item dimension into account for decoration materials

Notes
(0018176) Quietust (reporter) 2011-07-09 08:44	If you make a bunch of bars with [PRODUCT_DIMENSION:1] and then try to smith something, does the forge require multiple bars? If it does, then this is effectively a duplicate of 0000130 (albeit one with a proper explanation as to what's going on).

(0019874) Toady One (administrator) 2012-02-16 16:59	I've fixed the vanilla case, but I haven't looked at modded reactions yet.

Issue History
Date Modified	Username	Field	Change
2010-04-08 09:15	uprightpath	New Issue
2010-04-08 09:34	uprightpath	Tag Attached: forge
2010-04-08 09:34	uprightpath	Tag Attached: reagents
2010-04-08 09:34	uprightpath	Tag Attached: custom buildings
2010-04-08 09:34	uprightpath	Tag Attached: reactions
2010-04-09 03:40	Khym Chanur	Issue Monitored: Khym Chanur
2011-04-01 13:05	Footkerchief	Summary	PRODUCT_DIMENSION issues => Forges don't care if bars have a small PRODUCT_DIMENSION
2011-04-01 13:05	Footkerchief	Tag Attached: Intentional/Expected?
2011-07-09 02:51	Dwarfu	Relationship added	related to 0000130
2011-07-09 08:44	Quietust	Note Added: 0018176
2012-02-16 16:59	Toady One	Note Added: 0019874
2012-02-16 16:59	Toady One	Assigned To	=> Toady One
2012-02-16 16:59	Toady One	Status	new => acknowledged
2014-01-27 08:10	Footkerchief	Relationship added	related to 0006420