0001119: When Designating a Zone through Flow or Floor Flow, crashes when attempting to cancel using ESC key.

Notes
(0003389) Wyrframe (reporter) 2010-04-13 20:49	Ditto to reproducible always. On the last week of summer, right before auto-save, too. :'(

(0003393) Footkerchief (manager) 2010-04-13 21:01	I was able to reproduce this, but it's not as consistent as you made it sound. It seems to depend on the size of the zone and/or the zone flowing into open space.

(0003776) Cubittus (reporter) 2010-04-15 17:50 edited on: 2010-04-15 17:50	Just hit this one in 0.31.03. Just embarked and was making a drinking zone. Chose flow and hit enter on square beside brook then hit + twice to make a 5x5 square with two right columns over brook. Instead of confirming zone size by hitting enter again I hit ESC to cancel and boom - crashed.

(0003800) srycroft (reporter) 2010-04-15 22:00	Can reproduce consistently (Windows XP). I needed to have removed a zone before trying to escape out of creating a new flow/floor flow zone. It doesn't seem to matter what type of zone I removed or where it is in location to the cancelled zone. Example key-presses to reproduce: i,e,enter,enter,x,X,x,enter,ESC (crash)

(0004232) selbram (reporter) 2010-04-19 08:18	I can reproduce this as well in 0.31.03 on Windows 7. Exactly as described above, all you need to do is start to designate a zone with flow and decide to cancel, hit ESC, instead of hitting enter to designate and you get a crash every time.

(0006345) sojourner (reporter) 2010-05-07 03:23	Reproduced just now with 31.03 on WinXP - expand an activity zone to the maximum possible size, press ESC - fatal crash. The size of the zone was constrained by rock in the way around the edge, if that helps.

(0007656) bronwen (reporter) 2010-06-04 09:32	I just had it on 31.04 as well in designating a hospital zone, then cancelling because I'd forgotten to put doors on my hospital and the zone was spilling out too far.

(0007715) Toady One (administrator) 2010-06-05 05:36	I can't get this to happen. I tried everything described here. I don't see anything obvious in the cancellation code. A save with specific instructions might help, but not if it just happens anywhere fresh from any embark, because it doesn't work that way for me. Windows crash dumps might also help me find the problem line.

(0007831) tsoet (reporter) 2010-06-06 13:52 edited on: 2010-06-06 14:02	Here is a save that is totally reproducible. I had encountered this bug before and could not reproduce it - I agree that it seems to depend on several unknown factors. Save: http://www.mediafire.com/?mywmmooqtny [^] Alternatively (permanent, but not a fat pipe): http://www.tofof.org/bag/main-win-1053-spr-1054.zip [^] Steps to reproduce: Load game press i,e,enter,esc <crash> System: Windows XP 32-bit DF 0.31.05 Original instructions: Go to level -1 Press i (designate zone key) Move cursor to 1 tile north of floor hatch in green hospital area (10 beds in alcoves) Press e once (flow mode) Press enter Press + four times (flow should go up and stop at door on top, should just reach to hallway below), without entering it Press esc <crash> Quick tests on above instructions: You may omit the + resizing and still get crash. Placing in the 'waiting room' just north of green hospital also produces crash, so exact position doesn't seem to matter. Pressing i,e,enter,esc immediately on load (designating in middle of a wall between stockpile and diningroom) also produces crash. Putting the zone out in unmined rock also produces crash. Floor flow also crashes. Full disclosure: Edited raws. Can't see how this would break anything, but you should probably verify by dropping vanilla raws in place. Save was carried forward from 0.31.04. Again, since problem was reported in versions prior to that, I doubt that's the cause of anything but worth knowing.

(0007898) Kanddak (reporter) 2010-06-07 13:13	I was dumb and posted a duplicate of this a while ago, http://bay12games.com/dwarves/mantisbt/view.php?id=1922 [^] There's a mac crash dump there. I played around a lot with reproducing it at the time. It didn't seem to depend on any particular zone shape, any particular location, or any particular save. It just happened occasionally. Sometimes I had to mash enter/+/-/esc a couple dozen times to get a crash.

(0008033) Toady One (administrator) 2010-06-10 02:57	I tried everything from tsoet's save, but I'm not getting a crash. I don't know how to use mac crash dumps. Windows handles the debug symbols differently so I can use dumps without releasing them, but something similar might be possible on linux/mac. On my Windows XP, on a crash, a user.dmp file is created in C:\Documents and Settings\All Users\Application Data\Microsoft\Dr Watson and I can use those to find out more about the crash. I'm not sure where the file is placed in other Windows versions.

(0008192) neverknown (reporter) 2010-06-12 05:43 edited on: 2010-06-12 07:37	I lost 6 hours of play due to this crash and finding out that season auto save wasnt working (and still isnt) eventhough the .ini says otherwise edt: so I managed to create some (hopefully usefull!!) crash dumps.. which are quite big (packed with 7z ~70MB, unpacked 700MB). I did 3 of them at different times: http://drop.io/9nokyoh [^] 1. just ingame, everything should be normal here. http://drop.io/z1vhexk [^] 2. this is after I removed the said zone. http://drop.io/6gljp3t [^] 3. this is after i placed the Floor Flow zone. (when seeing the error window) (ill add the links as soon as they are uploaded) here is the event log if its usefull too: Faulting application name: Dwarf Fortress.exe, version: 0.0.0.0, time stamp: 0x4c0f83d5 Faulting module name: Dwarf Fortress.exe, version: 0.0.0.0, time stamp: 0x4c0f83d5 Exception code: 0xc0000005 Fault offset: 0x002da918 Faulting process id: 0xa58 Faulting application start time: 0x01cb0a3156b00210 Faulting application path: D:\Games\dwarf fortress\0.31.06\Dwarf Fortress.exe Faulting module path: D:\Games\dwarf fortress\0.31.06\Dwarf Fortress.exe Report Id: ed613cd0-7624-11df-af66-6cf049086752 So far, most of the times I can recreate the crash: removing an already existing zone with i,x,{position over zone},X,esc and then placing a flow floor zone somewhere.. with i,e,e,{position},enter,esc but I also crashed when not removing a zone doing the exact same thing.. o_o so wierd.. maybe I did something else? or I didnt remember that I already removed the zone. The zone removed is a meeting hall, NOT activated, spans over walls, doors, wells, Floor Bars built above open space, 1 "dining" meeting hall and 1 "well" meeting hall (the only thing between them was a door, maybe they touched each other), constructed Up/Down Stairs, a sculpture.. also, crashs with a max resized zone crashes slower than one which is not resized and the further away it is from the deleted zone. maybe that helps too? btw i didnt unpause the game doing this.. ill upload my save if needed, but now I gotta run :)

(0008228) Toady One (administrator) 2010-06-12 16:59	What are these? The user.dmp files I'm used to dealing with (created as described in my last note) have been around 20KB. I'm not sure how to use a memory dump to find the crash. It is different from the crash dump thingy created by Dr Watson. The little crash dump files will lead me to the exact line of code which crashes, and from there it's generally straightforward to fix. Are you on Windows? Does it create a user.dmp file when it crashes? The file is C:\Documents and Settings\All Users\Application Data\Microsoft\Dr Watson\user.dmp on my XP. I'm not sure if that holds for other versions of Windows.

(0008245) neverknown (reporter) 2010-06-12 23:18 edited on: 2010-06-13 00:05	oh sry I forgot to mention that I use windows 7, 64 bit.. I think I edited that out at one point. Anyway, win7 doesnt have a dr watson anymore, and these dumps I created are Memory Dumps (when rightclicking in the taskmanager on the dwarf fortress task and dump all the memory) I experimented further and acquired some debugging tools (called "windows debugging tools") which I can attach a process to and stuff.. it has several fancy stuff I dont understand but I think I found something useful.. Dwarf_Fortress+0x2da918: 0051a918 803c0a03 cmp byte ptr [edx+ecx],3 ds:002b:00000000=?? since they are debugging tools, they have things like watching variables and stuff.. if it isnt too complicated you can tell me what to watch out for.. in this case edx and ecx are 0. so says the "registers" window. If I had some kind of "symbols" (a "Dwarf Fortress.pdb" file) then the information will be less cryptic.

(0008369) Redd (reporter) 2010-06-13 18:16 edited on: 2010-06-13 19:31	Can confirm repeatable flow and floor flow crashes with 0.31.06. To repeat, at least on my system (x86 WinXP SP3), load the following save and press i, e, enter, esc. http://drop.io/j2q4n3b [^]

(0008392) Toady One (administrator) 2010-06-14 01:53	I'll need the rest of the save/region folder to load the world.sav file, especially the unit files and the raws if they were modded, but the whole thing is safer.

(0008405) neverknown (reporter) 2010-06-14 06:25 edited on: 2010-06-14 06:26	So I cant do anything with those debugging tools for you? :( Anyway.. if you need a save, I have the whole folder zipped here: http://drop.io/9y9whyi [^] from the starting point, go down 3 levels and you'll see a little dining hall and a 3 food stockpiles, to the right is a bridge over a river and some wells. here is a deactivated meeting hall zone. this is the one you need to remove. try making a flow or floor flow zone BEFORE removing, note that it will work. AFTER you removed the zone it wont, even after saving, exiting and starting/loading the game again.

(0009814) hyndis (reporter) 2010-07-08 22:33	Bah, just found out the hard way that this still exists in 31.08. Didn't lose that much luckily. Its 100% repeatable. Start creating the zone but then try to back out of creating it using the flow instead of rectangle method. Crashes every time.

(0009817) bicker x 2 (reporter) 2010-07-09 03:07	ran a debug after the crash i recieved this information Unhandled exception at 0x00e4db58 in Dwarf Fortress.exe: 0xC0000005: Access violation reading location 0x00000000. running 31.08 on windows vista 64 bit SP2

(0010512) vulcanius (reporter) 2010-07-17 15:04 edited on: 2010-07-17 15:05	Encountered this bug on Arch linux x86_64 with 0.31.10. Here is the console output. <snipped, lots of "Resizing font"...> Dwarf_Fortress: xcb_io.c:140: dequeue_pending_request: Assertion `req == dpy->xcb->pending_requests' failed. Aborted [cody@tritium libs]$ If you'd like I can try to recreate this and get a core dump.

(0010838) Antiscient (reporter) 2010-07-22 10:42 edited on: 2010-07-22 10:47	My mistake. I smartly assumed it was one of the recent version bugs and didn't look hard enough. Crashes make me sad, and I lost my first 0.31.10 fort upon finding this bug before saving. Anyway, if this helps, this is what shows up in the console log in OSX 10.6.4: * __NSAutoreleaseNoPool(): Object 0x19e03760 of class NSCFArray autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x1811a20 of class NSCFNumber autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x19d177b0 of class NSCFDictionary autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x1b00860 of class NSCFString autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x180c350 of class NSCFNumber autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x19d17660 of class NSCFDictionary autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x19d17dd0 of class NSCFArray autoreleased with no pool in place - just leaking * __NSAutoreleaseNoPool(): Object 0x1b58b60 of class SDL_QuartzWindow autoreleased with no pool in place - just leaking So, confirming Kanddak's submission.

(0010916) oolon1 (reporter) 2010-07-24 10:13 edited on: 2010-07-24 10:14	31.11, mod Ironhand 0.45, Vista SP2. Just to add some more detail to the report, I was attempting to fill an area of roughly 15x11 I thought was enclosed, realized it was spilling outside of the elliptical sort of room, and then tried to cancel. No other zone options were engaged. Also, it's triggered by whichever key is bound to "Leave Screen". Mine was spacebar. I don't have a save file for you because it was literally two minutes after embarking.

(0011064) zwei (reporter) 2010-07-26 02:29	Got it in 31.11, quite reproduceable on several woldgens/embarks Here is user.dmp and drwtsn32.log: http://drop.io/iyso9at [^]

(0011716) serum (reporter) 2010-08-11 07:44	Still getting this in 31.12 Using Win 7 64 Bit

(0011979) Spaz_Static (reporter) 2010-08-20 21:11 edited on: 2010-08-20 22:11	Ubuntu linux, 10.04, kernel 2.6.32-24.41, DF version 0.31.12. I too get this crash, not 100% of the time, but enough that I decided to register on Mantis because of it. If you need/want dump files and/or more system info, let me know where the files would reside and I can get them to you, or report info as required. [Edit]: OK, actually I think it is 100% of the time...

(0012454) Toady One (administrator) 2010-09-06 06:17	I was able to get zwei's dump loaded, and it narrowed down to one function. If that was actually the right place, I found a few things that may or may not be an issue and changed them. Certainly suspicious, but I don't get the crash myself, so it's hard to know if I've fixed the problem. We'll have to see if anything is different in 0.31.13.

(0012555) Gamli (reporter) 2010-09-09 17:45	This crash occurred 2 out of the 2 times I tried to place a zone like this in my save game. Would you like a copy?

(0012664) oolon1 (reporter) 2010-09-15 14:51	Did several attempts to reproduce this bug in 0.31.13, and so far it hasn't crashed the game. I could reproduce this bug 100% of the time with previous versions, so this is a good sign. I'll keep trying every few minutes in various locations around my fort.

(0015316) dree12 (reporter) 2011-02-20 09:03	No sign of any crashes anymore. It might be time to mark as fixed.

(0015645) Dwarfu (manager) 2011-03-01 15:45	I just checked 31.12 and reproduced it perfectly, but in 31.13 I can't get it to happen. Given Toady's note above, he most likely found the culprit and fixed it. I'll send it to him for final review.

(0015696) Toady One (administrator) 2011-03-03 04:03	Okay, I'll mark it off. Go ahead and reopen this if it crops up again.

Issue History
Date Modified	Username	Field	Change
2010-04-13 20:18	Avoozel	New Issue
2010-04-13 20:49	Wyrframe	Note Added: 0003389
2010-04-13 21:01	Footkerchief	Note Added: 0003393
2010-04-15 17:48	Stregone	Issue Monitored: Stregone
2010-04-15 17:50	Cubittus	Note Added: 0003776
2010-04-15 17:50	Cubittus	Note Edited: 0003776	View Revisions
2010-04-15 22:00	srycroft	Note Added: 0003800
2010-04-15 22:00	srycroft	Issue Monitored: srycroft
2010-04-19 08:18	selbram	Note Added: 0004232
2010-04-26 00:17	Footkerchief	Relationship added	parent of 0001461
2010-04-27 18:58	Footkerchief	Relationship added	related to 0000236
2010-04-28 17:31	Footkerchief	Relationship added	has duplicate 0001619
2010-05-01 14:24	Footkerchief	Relationship added	parent of 0001678
2010-05-07 03:23	sojourner	Note Added: 0006345
2010-05-17 07:57	Footkerchief	Relationship added	has duplicate 0001922
2010-06-03 14:52	Footkerchief	Relationship added	has duplicate 0002145
2010-06-03 14:52	Footkerchief	Sticky Issue	No => Yes
2010-06-04 09:32	bronwen	Note Added: 0007656
2010-06-05 05:36	Toady One	Note Added: 0007715
2010-06-05 05:36	Toady One	Assigned To	=> Toady One
2010-06-05 05:36	Toady One	Status	new => acknowledged
2010-06-06 13:52	tsoet	Note Added: 0007831
2010-06-06 13:52	tsoet	Issue Monitored: tsoet
2010-06-06 14:02	tsoet	Note Edited: 0007831	View Revisions
2010-06-07 13:13	Kanddak	Note Added: 0007898
2010-06-10 02:57	Toady One	Note Added: 0008033
2010-06-10 04:56	Logical2u	Relationship added	has duplicate 0002249
2010-06-12 05:43	neverknown	Note Added: 0008192
2010-06-12 06:00	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 06:02	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 06:03	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 06:28	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 06:40	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 06:46	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 07:00	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 07:03	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 07:04	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 07:37	neverknown	Note Edited: 0008192	View Revisions
2010-06-12 16:59	Toady One	Note Added: 0008228
2010-06-12 23:18	neverknown	Note Added: 0008245
2010-06-12 23:19	neverknown	Note Edited: 0008245	View Revisions
2010-06-12 23:19	neverknown	Note Edited: 0008245	View Revisions
2010-06-12 23:24	neverknown	Note Edited: 0008245	View Revisions
2010-06-13 00:05	neverknown	Note Edited: 0008245	View Revisions
2010-06-13 17:48	Redd	Issue Monitored: Redd
2010-06-13 17:49	Redd	Tag Attached: 0.31.06
2010-06-13 18:03	neverknown	Issue Monitored: neverknown
2010-06-13 18:16	Redd	Note Added: 0008369
2010-06-13 18:32	Redd	Note Edited: 0008369	View Revisions
2010-06-13 19:31	Redd	Note Edited: 0008369	View Revisions
2010-06-14 01:53	Toady One	Note Added: 0008392
2010-06-14 06:25	neverknown	Note Added: 0008405
2010-06-14 06:26	neverknown	Note Edited: 0008405	View Revisions
2010-07-08 22:33	hyndis	Note Added: 0009814
2010-07-09 03:07	bicker x 2	Note Added: 0009817
2010-07-17 15:04	vulcanius	Note Added: 0010512
2010-07-17 15:05	vulcanius	Note Edited: 0010512	View Revisions
2010-07-20 04:35	Logical2u	Relationship added	has duplicate 0002771
2010-07-20 04:35	Logical2u	Issue Monitored: Vercingetorix
2010-07-22 10:21	Footkerchief	Relationship added	has duplicate 0002782
2010-07-22 10:21	Footkerchief	Issue Monitored: Antiscient
2010-07-22 10:42	Antiscient	Note Added: 0010838
2010-07-22 10:47	Antiscient	Note Edited: 0010838	View Revisions
2010-07-24 10:13	oolon1	Note Added: 0010916
2010-07-24 10:14	oolon1	Note Edited: 0010916	View Revisions
2010-07-26 02:29	zwei	Note Added: 0011064
2010-07-26 02:29	zwei	Issue Monitored: zwei
2010-07-26 05:39	Threlicus	Issue Monitored: Threlicus
2010-07-28 20:52	Footkerchief	Relationship added	has duplicate 0002883
2010-07-31 03:14	dezbro	Issue Monitored: dezbro
2010-08-11 07:44	serum	Note Added: 0011716
2010-08-13 14:33	Dwarfu	Relationship added	has duplicate 0003021
2010-08-18 19:17	Logical2u	Relationship added	has duplicate 0003061
2010-08-20 21:11	Spaz_Static	Note Added: 0011979
2010-08-20 21:12	Spaz_Static	Note Edited: 0011979	View Revisions
2010-08-20 22:11	Spaz_Static	Note Edited: 0011979	View Revisions
2010-09-06 06:17	Toady One	Note Added: 0012454
2010-09-09 05:07	Dwarfu	Relationship added	has duplicate 0003185
2010-09-09 17:45	Gamli	Note Added: 0012555
2010-09-14 04:31	Logical2u	Relationship added	has duplicate 0003216
2010-09-15 14:51	oolon1	Note Added: 0012664
2011-02-20 09:03	dree12	Note Added: 0015316
2011-03-01 15:00	dree12	Tag Attached: Fixed in 0.31.13?
2011-03-01 15:45	Dwarfu	Note Added: 0015645
2011-03-01 15:52	Dwarfu	Tag Detached: Fixed in 0.31.13?
2011-03-03 04:03	Toady One	Note Added: 0015696
2011-03-03 04:03	Toady One	Status	acknowledged => resolved
2011-03-03 04:03	Toady One	Fixed in Version	=> 0.31.13
2011-03-03 04:03	Toady One	Resolution	open => fixed
2011-03-08 00:58	zwei	Issue End Monitor: zwei
2011-03-09 04:52	Dwarfu	Sticky Issue	Yes => No
2012-06-05 08:56	Threlicus	Issue End Monitor: Threlicus