0000378: Crash when selecting specific squad in military screen (daggers)

(0000855)
PolySoup (reporter)
2010-04-04 06:39

I've had the same thing happen to me, and have uploaded my save here: http://dffd.wimbli.com/file.php?id=1981 [^]

My first squad was all melee and the second were all ranged if that matters.

(0001393)
RACC (reporter)
2010-04-06 03:10

I have a save that reproduce this as well:

http://dl.dropbox.com/u/155636/df_mil_screen_crash.7z [^]

Steps to Reproduce:
1. (m) go to military screen
2. press (down) a few times to highlight the last squad in the Positions tab
3. crash.

(0001475)
Rafal99 (reporter)
2010-04-06 09:13

I have exactly the same crash. It crashes every time when you press (m) then (down) to select the next squad.
It crashes only in "Positions" tab. I tried avoiding this bug by going to "Equip" tab, then selecting the next squad, then going back to "Positions" tab, and in that case it crashed when I was going back to "Positions" tab with the second squad selected.
I may find a save if these above are not enough.

(0001667)
Lightning4 (reporter)
2010-04-06 21:29

I have a save now where this is reproducible as well. It was working fine for a while, but I noticed it consistently crashed after a while, while trying to form a military. In my case, it crashes trying to go to the first squad, as the first slot is taken by the captain of the guard.

(0001731)
Jiri Petru (reporter)
2010-04-07 06:20
edited on: 2010-04-07 06:32

Did more testing. Seems like the game crashes when I have more that 5 dwarves in a squad. Could someone try to confirm this?

EDIT: Nope, that's not it. Tried creating several squads with no more than 4 dwarves. Crashed nonetheless. Right now I'm trying to find the reason because it's making my game unplayable.

EDIT2: Whoever decides to test this: please note you have to make changes to the squad, then unpause the game and let it run for a few seconds before it notices the change.

(0001742)
Jiri Petru (reporter)
2010-04-07 07:48

!!!FOUND IT!!!

This problem is caused by equipping items, in my case a Large Bismuth Bronze Dagger left by a kobold thief. Whenever someone tried to equip that, it would cause a crash upon opening his squad in Military screen > Positions. After forbidding the dagger, I was able to draft my whole fort without trouble - before I could only get up to 10 dwarves, until thr 11th would claim the dagger (yeah, I don't have many weapons).

Download this save: http://dffd.wimbli.com/file.php?id=2019 [^]
Steps to reproduce:

1. Disband the whole military
2. In stocks menu, forbid all weapons except the large bismuth bronze dagger.
3. Draft the whole fort.
4. Unpause the game, let it run for a few second, go back to the military screen, try to select each of the squads, watch it crash.

Then try this:
1. Disband the whole military
2. In stocks menu, forbid the large bismuth bronze dagger.
3. Draft the whole fort.
4. Unpause the game, let it run for a few second, go back to the military screen, try to select each of the squads, watch it work perfectly.

Could someone who has the same problem in their game prove/disprove my theory?

(0001745)
Rafal99 (reporter)
2010-04-07 08:19

I tried dumping the two large daggers I have, one of which I equipped by a dwarf in my second squad - the one which crashes.
Waited for the daggers to be dumped, but it still crashes when I try to select the second squad in "Positions" tab.

But I have discovered another thing. When I go to military screen then "Equip" tab and deselect all items from all members of the second squad then wait a while, crash in "Positions" tab stops happening.

So it seems that not only daggers but some other item causes it too, gonna track it down.

(0001748)
Rafal99 (reporter)
2010-04-07 08:39
edited on: 2010-04-07 08:41

Well large daggers it is.

It didn't crash if I went to "Equip" tab and deselected only the dagger-wielding dwarf's weapon. He was assigned "Individual choice - melee", I can reassign him back and no crash, even if he still wields the dagger.

Only dumping the dagger without other changes didn't work for me. It was still crashing. It might be related to the fact that the dagger wielding dwarf is resting and is unconscious, so he has no chance to notice lack of his dagger and find a new weapon.

So yeah, solution seems to be to dump all large daggers and either wait for the dwarves to find another weapon or if your military screen doesn't crash in the first squad, go to 'Equip' tab, then remove and add again weapons to dagger-wielding dwarves.

(0001754)
Rafal99 (reporter)
2010-04-07 09:02

Changing [SKILL:DAGGER] to [SKILL:SWORD] in large dagger raw entry fixes this too.
I think the crash heppens when the game displays type of soldiers in the specific squad in "Positions" tab. It displays something like "2/2 Sworddwarves 4/4 Wrestlers" etc. Dwarves probably lack a name for knife user, gonna search the raws for proper fix.

(0001755)
SirPenguin (reporter)
2010-04-07 09:07

Good detective work, guys. I bet that's exactly what it is. Hopefully this saves Toady a lot of work.

(0001756)
Jiri Petru (reporter)
2010-04-07 09:20

High five! :D

(0001757)
DoctorZuber (reporter)
2010-04-07 09:23

Nice work, from the title that one looked tricky to find, and here you guys seem to have it all sorted out already. Good Job!

(0001759)
Rafal99 (reporter)
2010-04-07 09:29

Ok the skill change is the only fix I found.
Adding [PROFESSION_NAME:THIEF:knifedwarf:knifedwarves] to dwarf raw entry didn't fix it, so lack of knife user name isn't the direct cause of this bug.

Someone should test if other weapons requiring strange skills like for example Whip and Scourge cause this crash too.

I am going to post in the forums about the fix.

(0001770)
Rafal99 (reporter)
2010-04-07 10:01

Here is the forum thread:
http://www.bay12games.com/forum/index.php?topic=53371.0 [^]

Hope it helps some people.

(0001785)
freeze (reporter)
2010-04-07 10:33

Excellent.. change [SKILL:DAGGER] to [SKILL:SWORD] worked on my "press m instacrash" game

(0001824)
DoctorZuber (reporter)
2010-04-07 12:26

0000444 0000536

I wouldn't close 0000536 yet, but there seems to be a similar behavior going on here.

(0002596)
Jiri Petru (reporter)
2010-04-10 10:03

Daggers still cause problems for me, but for some reason I can't fix it by rewriting them to [SKILL:SWORD]. Forbidding the dagger and waiting a while till the soldier dropped it helped, though.

(0002652)
Rafal99 (reporter)
2010-04-10 14:52

Are you replacing the correct raws?
The ones actually used are in your save folder.

(0002654)
Jiri Petru (reporter)
2010-04-10 15:09

Yup, the save folder. It helped once, but then it started crashing again with SKILL:SWORD. But I guess this has to be a problem between my keyboard and the chair. For the time being, I forbid all daggers and wait for Toady to fix it :)

(0003190)
RichardCorey (reporter)
2010-04-12 20:23

I am having the same crash with no daggers being involved so far as I can tell. We do have a dagger in a weapon trap, but it's not involved at all. My one squad is set to short swords, and the one I can't select is set to "your choice ranged", but they aren't active at all, nor have we retrieved any ranged weapons from invaders.

http://dffd.wimbli.com/file.php?id=2084 [^]

(0006124)
Etch (reporter)
2010-05-04 16:30

I have a save which also crashed whenever I pressed m to access the military screen, and which was fixed by rewriting SKILL:DAGGER to SKILL:SWORD. Have yet to play further in that save to see if the fix is permanent or not.

However, looking through my millitary (2 squads, 13 dwarves), none of my dwarves are wielding any daggers, and in fact the only dagger of any kind is a large iron dagger, originating I believe from a goblin thief, sitting in a weapon stockpile in my barracks. Reverting the change in the raws and checking the only two dwarves who had any skill in sword use (dabbling & proficient) in the first squad post-fix showed that neither of them had any skill in dagger use pre-fix.

(0006701)
Jiri Petru (reporter)
2010-05-14 16:07

I suggest renaming this thread to: "Large Daggers Cause Crash on Military Screen"

(0007382)
DarthCloakedDwarf (reporter)
2010-05-27 08:24

Crash confirmed in 31.04. It's still there.

(0008131)
Footkerchief (manager)
2010-06-11 05:28

Save from 0002275: http://dl.dropbox.com/u/4436079/region1.7z [^]

(0008251)
Toady One (administrator)
2010-06-13 01:10

I've fixed up the 0002275 save for 0.31.07 (daggers, indeed). I'll check through the others as possible and then mark off this family (if it is all this issue).

Issue History
Date Modified	Username	Field	Change
2010-04-04 03:37	Jiri Petru	New Issue
2010-04-04 06:39	PolySoup	Note Added: 0000855
2010-04-06 03:10	RACC	Note Added: 0001393
2010-04-06 09:13	Rafal99	Note Added: 0001475
2010-04-06 09:51	Rafal99	Issue Monitored: Rafal99
2010-04-06 21:29	Lightning4	Note Added: 0001667
2010-04-07 06:20	Jiri Petru	Note Added: 0001731
2010-04-07 06:20	Jiri Petru	Note Edited: 0001731	View Revisions
2010-04-07 06:30	Jiri Petru	Note Edited: 0001731	View Revisions
2010-04-07 06:32	Jiri Petru	Note Edited: 0001731	View Revisions
2010-04-07 07:48	Jiri Petru	Note Added: 0001742
2010-04-07 08:00	Rafal99	Tag Attached: military screen
2010-04-07 08:00	Rafal99	Tag Attached: crash
2010-04-07 08:01	Jiri Petru	Tag Attached: Equipment
2010-04-07 08:19	Rafal99	Note Added: 0001745
2010-04-07 08:39	Rafal99	Note Added: 0001748
2010-04-07 08:40	Rafal99	Tag Attached: large dagger
2010-04-07 08:41	Rafal99	Note Edited: 0001748	View Revisions
2010-04-07 09:02	Rafal99	Note Added: 0001754
2010-04-07 09:07	SirPenguin	Note Added: 0001755
2010-04-07 09:20	Jiri Petru	Note Added: 0001756
2010-04-07 09:23	DoctorZuber	Note Added: 0001757
2010-04-07 09:29	Rafal99	Note Added: 0001759
2010-04-07 10:01	Rafal99	Note Added: 0001770
2010-04-07 10:33	freeze	Note Added: 0001785
2010-04-07 12:26	DoctorZuber	Note Added: 0001824
2010-04-10 10:03	Jiri Petru	Note Added: 0002596
2010-04-10 14:52	Rafal99	Note Added: 0002652
2010-04-10 15:09	Jiri Petru	Note Added: 0002654
2010-04-10 21:40	RACC	Issue Monitored: RACC
2010-04-12 20:23	RichardCorey	Note Added: 0003190
2010-04-16 08:48	Footkerchief	Relationship added	parent of 0001063
2010-04-16 08:48	Footkerchief	Relationship added	parent of 0001228
2010-04-16 14:03	warmist	Issue Monitored: warmist
2010-04-18 15:24	RACC	Issue End Monitor: RACC
2010-04-20 09:42	Footkerchief	Relationship added	parent of 0001364
2010-04-29 17:37	Footkerchief	Relationship added	parent of 0001222
2010-04-29 17:37	Footkerchief	Relationship added	parent of 0001647
2010-04-29 17:38	Footkerchief	Relationship added	parent of 0001644
2010-04-29 17:51	Footkerchief	Relationship added	parent of 0001442
2010-05-01 05:19	Logical2u	Relationship added	related to 0000536
2010-05-04 16:30	Etch	Note Added: 0006124
2010-05-04 23:48	Footkerchief	Relationship added	parent of 0001748
2010-05-14 16:07	Jiri Petru	Note Added: 0006701
2010-05-16 06:23	Logical2u	Relationship added	has duplicate 0001874
2010-05-27 08:24	DarthCloakedDwarf	Note Added: 0007382
2010-06-11 05:27	Footkerchief	Relationship added	has duplicate 0002275
2010-06-11 05:28	Footkerchief	Note Added: 0008131
2010-06-12 12:56	Footkerchief	Summary	Crash whenever I try to select a specific squad => Crash when selecting specific squad in military screen
2010-06-12 12:56	Footkerchief	Sticky Issue	No => Yes
2010-06-13 01:10	Toady One	Note Added: 0008251
2010-06-13 01:10	Toady One	Assigned To	=> Toady One
2010-06-13 01:10	Toady One	Status	new => acknowledged
2010-06-13 01:36	Toady One	Relationship replaced	related to 0001647
2010-06-13 01:37	Toady One	Relationship replaced	related to 0001644
2010-06-13 02:05	Toady One	Status	acknowledged => resolved
2010-06-13 02:05	Toady One	Fixed in Version	=> 0.31.07
2010-06-13 02:05	Toady One	Resolution	open => fixed
2010-06-13 02:08	Footkerchief	Summary	Crash when selecting specific squad in military screen => Crash when selecting specific squad in military screen (daggers)
2010-06-13 02:10	Footkerchief	Relationship added	parent of 0000444
2010-06-13 04:37	Rafal99	Issue End Monitor: Rafal99
2010-06-13 10:11	Footkerchief	Relationship deleted	related to 0001644
2010-06-13 10:11	Footkerchief	Relationship deleted	related to 0001647
2010-06-13 12:51	Footkerchief	Sticky Issue	Yes => No
2010-06-14 14:11	warmist	Issue End Monitor: warmist
2010-06-17 05:16	Footkerchief	Relationship added	has duplicate 0002359
2012-03-30 19:59	Footkerchief	Relationship added	has duplicate 0001647
2012-03-30 19:59	Footkerchief	Issue Monitored: Footkerchief

Notes
(0000855) PolySoup (reporter) 2010-04-04 06:39	I've had the same thing happen to me, and have uploaded my save here: http://dffd.wimbli.com/file.php?id=1981 [^] My first squad was all melee and the second were all ranged if that matters.

(0001393) RACC (reporter) 2010-04-06 03:10	I have a save that reproduce this as well: http://dl.dropbox.com/u/155636/df_mil_screen_crash.7z [^] Steps to Reproduce: 1. (m) go to military screen 2. press (down) a few times to highlight the last squad in the Positions tab 3. crash.

(0001475) Rafal99 (reporter) 2010-04-06 09:13	I have exactly the same crash. It crashes every time when you press (m) then (down) to select the next squad. It crashes only in "Positions" tab. I tried avoiding this bug by going to "Equip" tab, then selecting the next squad, then going back to "Positions" tab, and in that case it crashed when I was going back to "Positions" tab with the second squad selected. I may find a save if these above are not enough.

(0001667) Lightning4 (reporter) 2010-04-06 21:29	I have a save now where this is reproducible as well. It was working fine for a while, but I noticed it consistently crashed after a while, while trying to form a military. In my case, it crashes trying to go to the first squad, as the first slot is taken by the captain of the guard.

(0001731) Jiri Petru (reporter) 2010-04-07 06:20 edited on: 2010-04-07 06:32	Did more testing. Seems like the game crashes when I have more that 5 dwarves in a squad. Could someone try to confirm this? EDIT: Nope, that's not it. Tried creating several squads with no more than 4 dwarves. Crashed nonetheless. Right now I'm trying to find the reason because it's making my game unplayable. EDIT2: Whoever decides to test this: please note you have to make changes to the squad, then unpause the game and let it run for a few seconds before it notices the change.

(0001742) Jiri Petru (reporter) 2010-04-07 07:48	!!!FOUND IT!!! This problem is caused by equipping items, in my case a Large Bismuth Bronze Dagger left by a kobold thief. Whenever someone tried to equip that, it would cause a crash upon opening his squad in Military screen > Positions. After forbidding the dagger, I was able to draft my whole fort without trouble - before I could only get up to 10 dwarves, until thr 11th would claim the dagger (yeah, I don't have many weapons). Download this save: http://dffd.wimbli.com/file.php?id=2019 [^] Steps to reproduce: 1. Disband the whole military 2. In stocks menu, forbid all weapons except the large bismuth bronze dagger. 3. Draft the whole fort. 4. Unpause the game, let it run for a few second, go back to the military screen, try to select each of the squads, watch it crash. Then try this: 1. Disband the whole military 2. In stocks menu, forbid the large bismuth bronze dagger. 3. Draft the whole fort. 4. Unpause the game, let it run for a few second, go back to the military screen, try to select each of the squads, watch it work perfectly. Could someone who has the same problem in their game prove/disprove my theory?

(0001745) Rafal99 (reporter) 2010-04-07 08:19	I tried dumping the two large daggers I have, one of which I equipped by a dwarf in my second squad - the one which crashes. Waited for the daggers to be dumped, but it still crashes when I try to select the second squad in "Positions" tab. But I have discovered another thing. When I go to military screen then "Equip" tab and deselect all items from all members of the second squad then wait a while, crash in "Positions" tab stops happening. So it seems that not only daggers but some other item causes it too, gonna track it down.

(0001748) Rafal99 (reporter) 2010-04-07 08:39 edited on: 2010-04-07 08:41	Well large daggers it is. It didn't crash if I went to "Equip" tab and deselected only the dagger-wielding dwarf's weapon. He was assigned "Individual choice - melee", I can reassign him back and no crash, even if he still wields the dagger. Only dumping the dagger without other changes didn't work for me. It was still crashing. It might be related to the fact that the dagger wielding dwarf is resting and is unconscious, so he has no chance to notice lack of his dagger and find a new weapon. So yeah, solution seems to be to dump all large daggers and either wait for the dwarves to find another weapon or if your military screen doesn't crash in the first squad, go to 'Equip' tab, then remove and add again weapons to dagger-wielding dwarves.

(0001754) Rafal99 (reporter) 2010-04-07 09:02	Changing [SKILL:DAGGER] to [SKILL:SWORD] in large dagger raw entry fixes this too. I think the crash heppens when the game displays type of soldiers in the specific squad in "Positions" tab. It displays something like "2/2 Sworddwarves 4/4 Wrestlers" etc. Dwarves probably lack a name for knife user, gonna search the raws for proper fix.

(0001755) SirPenguin (reporter) 2010-04-07 09:07	Good detective work, guys. I bet that's exactly what it is. Hopefully this saves Toady a lot of work.

(0001756) Jiri Petru (reporter) 2010-04-07 09:20	High five! :D

(0001757) DoctorZuber (reporter) 2010-04-07 09:23	Nice work, from the title that one looked tricky to find, and here you guys seem to have it all sorted out already. Good Job!

(0001759) Rafal99 (reporter) 2010-04-07 09:29	Ok the skill change is the only fix I found. Adding [PROFESSION_NAME:THIEF:knifedwarf:knifedwarves] to dwarf raw entry didn't fix it, so lack of knife user name isn't the direct cause of this bug. Someone should test if other weapons requiring strange skills like for example Whip and Scourge cause this crash too. I am going to post in the forums about the fix.

(0001770) Rafal99 (reporter) 2010-04-07 10:01	Here is the forum thread: http://www.bay12games.com/forum/index.php?topic=53371.0 [^] Hope it helps some people.

(0001785) freeze (reporter) 2010-04-07 10:33	Excellent.. change [SKILL:DAGGER] to [SKILL:SWORD] worked on my "press m instacrash" game

(0001824) DoctorZuber (reporter) 2010-04-07 12:26	0000444 0000536 I wouldn't close 0000536 yet, but there seems to be a similar behavior going on here.

(0002596) Jiri Petru (reporter) 2010-04-10 10:03	Daggers still cause problems for me, but for some reason I can't fix it by rewriting them to [SKILL:SWORD]. Forbidding the dagger and waiting a while till the soldier dropped it helped, though.

(0002652) Rafal99 (reporter) 2010-04-10 14:52	Are you replacing the correct raws? The ones actually used are in your save folder.

(0002654) Jiri Petru (reporter) 2010-04-10 15:09	Yup, the save folder. It helped once, but then it started crashing again with SKILL:SWORD. But I guess this has to be a problem between my keyboard and the chair. For the time being, I forbid all daggers and wait for Toady to fix it :)

(0003190) RichardCorey (reporter) 2010-04-12 20:23	I am having the same crash with no daggers being involved so far as I can tell. We do have a dagger in a weapon trap, but it's not involved at all. My one squad is set to short swords, and the one I can't select is set to "your choice ranged", but they aren't active at all, nor have we retrieved any ranged weapons from invaders. http://dffd.wimbli.com/file.php?id=2084 [^]

(0006124) Etch (reporter) 2010-05-04 16:30	I have a save which also crashed whenever I pressed m to access the military screen, and which was fixed by rewriting SKILL:DAGGER to SKILL:SWORD. Have yet to play further in that save to see if the fix is permanent or not. However, looking through my millitary (2 squads, 13 dwarves), none of my dwarves are wielding any daggers, and in fact the only dagger of any kind is a large iron dagger, originating I believe from a goblin thief, sitting in a weapon stockpile in my barracks. Reverting the change in the raws and checking the only two dwarves who had any skill in sword use (dabbling & proficient) in the first squad post-fix showed that neither of them had any skill in dagger use pre-fix.

(0006701) Jiri Petru (reporter) 2010-05-14 16:07	I suggest renaming this thread to: "Large Daggers Cause Crash on Military Screen"

(0007382) DarthCloakedDwarf (reporter) 2010-05-27 08:24	Crash confirmed in 31.04. It's still there.

(0008131) Footkerchief (manager) 2010-06-11 05:28	Save from 0002275: http://dl.dropbox.com/u/4436079/region1.7z [^]

(0008251) Toady One (administrator) 2010-06-13 01:10	I've fixed up the 0002275 save for 0.31.07 (daggers, indeed). I'll check through the others as possible and then mark off this family (if it is all this issue).