0001428: Backup raws files (*.txt~, *.txt.bak) get parsed, causing mismatched IDs and crashes

Issue History
Date Modified	Username	Field	Change
2010-04-22 06:03	ethanb	New Issue
2010-04-22 06:03	ethanb	Issue Monitored: ethanb
2010-04-22 06:03	ethanb	Issue End Monitor: ethanb
2010-04-22 06:34	Knight Otu	Note Added: 0004587
2010-04-22 09:24	Footkerchief	Note Added: 0004606
2010-04-22 09:43	Knight Otu	Note Added: 0004608
2010-04-22 11:30	Footkerchief	Note Added: 0004625
2010-04-22 11:33	Footkerchief	Summary	crash when viewing specific site in Legends => Backup raws file (creature_standard.txt~) gets parsed with other raws, causing mismatched IDs and crashes
2010-04-22 11:40	Kennel	Tag Attached: crash
2010-04-22 11:40	Kennel	Tag Attached: legends
2010-04-22 11:40	Kennel	Tag Attached: raw file
2010-04-22 21:30	ethanb	Note Added: 0004673
2010-04-28 10:04	Footkerchief	Note Added: 0005548
2010-04-28 10:04	Footkerchief	Summary	Backup raws file (creature_standard.txt~) gets parsed with other raws, causing mismatched IDs and crashes => Backup raws file (creature_standard.txt~, creature_standard.txt.bak) gets parsed, causing mismatched IDs and crashes
2010-04-28 13:53	Footkerchief	Category	General => Technical
2010-05-04 11:02	Footkerchief	Relationship added	parent of 0001200
2010-05-17 01:21	Footkerchief	Relationship deleted	parent of 0001200
2010-06-29 07:38	Footkerchief	Category	Technical => Technical -- General
2010-07-12 09:46	Footkerchief	Relationship added	has duplicate 0002654
2010-07-12 10:04	Naros	Note Added: 0010040
2010-07-12 12:52	Footkerchief	Relationship added	has duplicate 0002022
2010-07-12 12:52	Footkerchief	Issue Monitored: Footkerchief
2010-07-12 12:52	Footkerchief	Issue Monitored: almostsix
2010-07-12 12:52	Footkerchief	Issue Monitored: ChickenLips
2010-07-12 12:52	Footkerchief	Sticky Issue	No => Yes
2010-07-12 12:52	Footkerchief	Summary	Backup raws file (creature_standard.txt~, creature_standard.txt.bak) gets parsed, causing mismatched IDs and crashes => Backup raws files (creature_standard.txt~, creature_standard.txt.bak) get parsed, causing mismatched IDs and crashes
2010-07-12 12:53	Footkerchief	Summary	Backup raws files (creature_standard.txt~, creature_standard.txt.bak) get parsed, causing mismatched IDs and crashes => Backup raws files (.txt~, .txt.bak) get parsed, causing mismatched IDs and crashes
2010-07-25 11:52	ChickenLips	Issue End Monitor: ChickenLips
2010-11-05 13:41	Another	Tag Attached: gameplay tweak
2010-11-12 19:06	Logical2u	Relationship added	has duplicate 0003565
2010-11-13 13:49	rofl0r	Note Added: 0013777
2010-11-16 16:53	InsanityPrelude	Note Added: 0013941
2010-12-11 12:14	Dwarfu	Relationship added	has duplicate 0000446
2011-02-05 17:43	Dwarfu	Relationship added	has duplicate 0001597
2011-02-05 17:43	Dwarfu	Issue Monitored: Dae
2011-02-05 17:43	Dwarfu	Issue Monitored: nil
2011-02-12 01:54	Khym Chanur	Issue Monitored: Khym Chanur
2011-03-09 04:01	Toady One	Status	new => resolved
2011-03-09 04:01	Toady One	Fixed in Version	=> 0.31.22
2011-03-09 04:01	Toady One	Resolution	open => fixed
2011-03-09 04:01	Toady One	Assigned To	=> Toady One
2011-03-09 04:52	Dwarfu	Sticky Issue	Yes => No
2011-03-09 17:25	Khym Chanur	Issue End Monitor: Khym Chanur
2011-06-28 12:36	Dwarfu	Relationship added	has duplicate 0004707
2016-09-03 05:48	Loci	Relationship added	related to 0009988

Notes
(0004587) Knight Otu (manager) 2010-04-22 06:34	You have a creature_standard.txt~ file (not creature_standard.txt) in your raws folder. That caused a heavy bout of duplicate object errors. Delete that file and generate the world anew. Deleting it from the save's raw folder won't save the world.

(0004606) Footkerchief (manager) 2010-04-22 09:24	Knight Otu: Does that appear to be the cause of the crash? Usually it at least pops up an error message when the raws are messed up.

(0004608) Knight Otu (manager) 2010-04-22 09:43	It appears to be. The error log does include the duplicate objects warning, and I believe there has always been the potential for legends crashes when vermin somehow became involved. Let's see, apparently his dwarves became mountain goats, elves became giant eagles, goblins became mountain gnomes, and humans became hoary marmots, but one of the megabeasts appears to have become a lizard and another one a red-winged blackbird - looking at one of those causes a crash. There are also demons without a demon type, which also crash when looked at. The file (I guess it's an automatic backup file) and the resulting creature shift does seem to be the cause. The true bug here, presumably, would be that DF reads non-text files if they are otherwise in the correct format.

(0004625) Footkerchief (manager) 2010-04-22 11:30	Haha. Yeah, good call, I'll retitle the report.

(0004673) ethanb (reporter) 2010-04-22 21:30	Ah, that would explain it! Naughty vim, making backup files! It's ok, only the second facepalm today. The first was at work while my boss was trying to go home - much more embarrassing.

(0005548) Footkerchief (manager) 2010-04-28 10:04	It's reported here that this happens with .bak files as well: http://www.bay12forums.com/smf/index.php?topic=55809.msg1204985#msg1204985 [^]

(0010040) Naros (reporter) 2010-07-12 10:04	The obvious suggested fix for this would be to only parse raws that have the 'txt' extention. Ultimately the modders are to blame for our own inattentiveness, though if such a fix doesn't cause any issues it would make life a bit easier for said modders.

(0013777) rofl0r (reporter) 2010-11-13 13:49	thats a 3 minute fix, but toady obviously doesnt care whats going on here on the bugtracker. i have the feeling he fixes only the bugs he encounters himself, but only those who annoy him the most.

(0013941) InsanityPrelude (reporter) 2010-11-16 16:53	Pessimistic, aren't you? There's a lot of bugs and Toady's only one guy.