0007447: Brewing doesn't work - Dwarf Fortress Bug Tracker

Notes
(0026847) Khym Chanur (reporter) 2014-07-18 02:12	Might be related to bug 0007423, where I have no problem brewing plump helmets but can't brew fruits.

(0026858) Footkerchief (manager) 2014-07-18 07:43 edited on: 2014-07-18 07:53	NOTE FROM THE MANAGERS This is a clone of a slightly older report that got messed up by the accidental sending of like a thousand reminders. Here's a screenshot of the older report: http://dffd.wimbli.com/file.php?id=9052 [^] And a plain text version for your copy-pasting pleasure: http://pastebin.com/raw.php?i=Q1hmc3p6 [^] The current status is that we're still waiting for a save that shows broken brewing in a way that's not explained by 0000434 or by the plant barrels being hauled.

(0027342) Knight Otu (manager) 2014-07-23 12:34	A custom reaction of mine has spurred me to some tests, and I'm pretty sure that brewing works, at least brewing plants, because 0003224 has been partially resolved - reactions can at least look for PLANT items in containers, and presumably for PLANT_GROWTH items. (0003224 can still cause problems for modding, though - reactions at least cannot look for NONE placeholder items in barrels, something I had done to reduce reaction clutter - it worked once I changed it to PLANT and got my dwarves to put the plants in question into a barrel. Whether real item types are affected I can't say for certain.)

(0027617) Dwarfu (manager) 2014-07-26 09:17	For anyone having issues, please note that if you have plant stockpiles giving to a still, the still also needs a furniture stockpile (with empty barrels) giving to it as well. The same would go for any workshop using a reaction requiring a separate container.

(0027713) torrenal (reporter) 2014-07-27 14:59	I've had the same thing happen as reported here. No stockpiles giving to the still, available food, etc. I'd fixed it by putting a brewables stockpile adjacent to the Still. I can upload a save where it's broken if anyone wants to take a look.

(0027717) Footkerchief (manager) 2014-07-27 15:04 edited on: 2014-07-27 15:06	torrenal: is it explained by the still being in a burrow? If not, please upload the save to http://dffd.wimbli.com/ [^] and post the link here.

(0027726) torrenal (reporter) 2014-07-27 15:35	Bloody... Ok, a quick test while I was waiting on the upload gave me odd results: I only have one Burrow, the 'Get everyone indoors' burrow I use for sieges & such. The burrow has no members. The active alert 'Inactive' does not include the burrow - My understanding is this Burrow has no effect on anything in any way, until I add dwarves or the current Civilian Alert includes it. The still is physically within the burrow. My current food stockpiles are not (I haven't needed the burrow for a while) If I add the food stockpiles to the burrow, I can brew. My understanding of the correct operation of burrows would not explain the bug, but modifying my burrows does impact what I see. The save, if you still want it is: http://dffd.wimbli.com/file.php?id=9176 [^]

(0028351) fortunawhisk (reporter) 2014-08-04 21:39 edited on: 2014-08-04 21:54	Problem appears to be the still automatically picks up the boundaries of any burrow it is placed in. For the 9176 save, fixes are: - Remove the burrow - Extend the burrow to cover z91 (where the plant barrels are) - Build another still on z91, outside the "Inside" burrow This can replicated in a default 40.06 embark. - Embark - Build a still and a carpenter - Build a barrel at the carpenter - Validate still now has Brew drink option - Create a burrow over the still (can be paused here) - Brew drink goes away - Extend burrow over carpenter and wagon - Brew drink comes back Note: You can still queue brewing a drink via the manager, and it will complete whether the still is in the burrow or not.

(0028542) lethosor (manager) 2014-08-07 15:44 edited on: 2014-08-07 18:37	That makes this report sound a lot like 0000434. Has anyone been able to reproduce this without any burrows? (Edit: 0007447:0028556)

(0028545) Loci (manager) 2014-08-07 16:59	The problem is there are at least four different brewing bugs at present. Sorting out which one is responsible for each issue isn't easy. 1.)Burrows erroneously apply to workshop reactions, which brewing now is 2.)Hauling issues 3.)Dozens of plants aren't brewable because their handling code is incomplete (including strawberries) 4.)Brewable fruits purchased at embark don't work because they come in bags 5.)Corrupted raws (mis-installation) can disable brewing entirely (not a bug, but still a wide-spread source of confusion) We really need to get some of these issues sorted out so we can determine whether or not there are any underlying issues.

(0028554) Footkerchief (manager) 2014-08-07 18:16	Loci -- those should all be related to this report now, except for 5, which is probably not solvable.

(0028556) lethosor (manager) 2014-08-07 18:37	According to 0007896, this can occur without burrows.

(0028701) torrenal (reporter) 2014-08-09 23:33	Not only are there bugs present, but even without bugs, it's bloody easy to put yourself into a situation where you can't brew. I'd appreciate a little feedback as to what specifically is blocking a brew - could you flag the reagents the game sees as unavailable? Then at least I'd know at a glance if the issue was getting brewable food to the still, or daft me forgetting to make more barrels...

(0028891) psisquared (reporter) 2014-08-12 12:27	I just started a game Linux v40.08 and brewing isn't an option at all in the still, using a manager, or in the kitchen menu. Here is the save: http://dffd.wimbli.com/file.php?id=9369 [^]

(0028898) fortunawhisk (reporter) 2014-08-12 13:41	@psisquared: From the 9369 save, your raws appeared to be modified from the 40.08 defaults. Specifically, the plants_standard is missing (what I think is) the brew reaction for the plants. [MATERIAL_REACTION_PRODUCT:DRINK_MAT:LOCAL_PLANT_MAT:DRINK] Unfortunately, just adding it back and restarting is not enough to fix. If you could post what pack/launcher/graphics set you're using, that may help others with the same problem. Plant raws actually appear to resemble the 34.11 branch?

(0028899) Loci (manager) 2014-08-12 13:45	@psisquared: Your raws are scrogged (0006849). In particular, reaction_other.txt is missing entries for [REACTION:BREW_DRINK_FROM_PLANT] [REACTION:BREW_DRINK_FROM_PLANT_GROWTH] Try a fresh install, and avoid using any mods or utilities designed for older versions.

(0028902) fortunawhisk (reporter) 2014-08-12 14:51	In case it proves useful: https://imgur.com/1dsqy2l [^] Top shot shows "can't brew" due to broken raws. Bot shot shows "can't brew" due to no plants, no containers, burrows, etc.

(0028903) psisquared (reporter) 2014-08-12 15:57	Thanks for the help. Sorry to waste bug squashing time. The only mod I was using was the Obsidian tileset. I must have screwed something up installing it.

(0029345) JoshuaRaven (reporter) 2014-08-20 01:17	http://dffd.wimbli.com/file.php?id=9455 [^] I am having the exact same issue. - 40.08 - Using "Starter Pack" with DFHack. - During this save, brewing used to work, but somehow it stopped working - Plenty of "Plump Helmet" available - Some empty barrels - No (relevant) stockpile links - I do have a "go inside" civilian burrow, but both the still and stockpiles are part of it

(0029346) Rafal99 (reporter) 2014-08-20 02:16 edited on: 2014-08-20 02:16	I tested JoshuaRaven's save ( http://dffd.wimbli.com/file.php?id=9455 [^] ). Brew Drink job is red, but looking at the detailed view in stocks screen, there is not a single empty barrel that is not already assigned to a stockpile. There is 93 barrels total but all of them are used. So I did these steps: - set reserved barrels to 5 - ordered carpenter to make a barrel and waited until he finishes - waited until the new barrel gets moved to stockpile - Brew Drink job became available, so I ordered it - the dwarf successfully grabbed a barrel and some Plump Helmets and completed the job producing a drink. So there is no bug in that save.

(0029349) JoshuaRaven (reporter) 2014-08-20 02:59	That was awkward. I did test that there where empty barrels (but the save might be from a different moment). Maybe I was affected by the "barrel in use by hauling", but the empty barrel was sitting in the stockpile, so that might be why I missed that. You are right that I tested it again, and it now works, so please ignore my comment.

(0029736) thriggle (reporter) 2014-08-27 20:54	I saw people complaining about this bug on reddit mention that repeatedly dismantling and rebuilding the still eventually made the problem go away. Witnessed this myself and I think I've made a connection: the game is allowing you to build a still without requiring obstacles (i.e. boulders) to be first removed from the construction zone. Possible that a still built with a boulder resting within its boundaries has its Brew drink job disabled. Repeatedly dismantling the still seems to move the boulder around until it's not in the area; you could theoretically also manually clear the area by dumping it. Will do further testing to confirm.

(0029740) Loci (manager) 2014-08-28 04:44	It is more likely that dismantling and rebuilding the still keeps the player preoccupied while the dwarf with the fortress's only plant barrel gets done hauling it across the map to pick up the useless grape vines that the herbalist "gathered". All buildings (stills included) should cause the constructing dwarf to move any obstructing items to an adjacent tile. If you build your workshops directly next to each other, the items from the second workshop's tiles may end up placed on top of the first workshop. Items on top of a building, however, appear to have no impact on the functionality of the building. I tested this in 0.40.10; items were correctly cleared from the still's building site, and after I dumped several rocks on top of the still it remained functional.

(0030336) arcosanti (reporter) 2014-09-23 17:39 edited on: 2014-09-23 17:39	I believe Loci's comment is correct. I just encountered this bug in 0.40.13 with the conditions that appear to be: - plants and fruit exist to be brewed and are set brewable in the kitchen - empty barrels exist - all plant barrels are currently in the inventory of dwarves on their way to farm plots that have harvestable food This is with no burrows, no fruits/plants purchased at embark, and vanilla DF. As such, it seems to be strictly related to hauling. I can provide the save if desired.

(0030371) drumr (reporter) 2014-09-26 00:20	v 0.40.12 from DF Starter Pack http://www.bay12forums.com/smf/index.php?topic=126076 [^] This is my 3rd game/fortress from this install. I was able to brew in other games but no more. DF Starter Pack Settings I changed for the 3rd game: Invaders: no, Child Cap 1:1 I also built 2 Stills right away, which I hadn't done before. Stocks show 15 barrels. I can see them in the stockpile. Drinks: 0 Kitchen shows 'COOK'able: pig tail seeds plump helmet spawn cave wheat seeds sweet pod seeds rock nuts plump helmets turkey tallow fox tallow None of these have a 'BREW' option to enable. They all have '- - - -' for the last column. After reading suggestions here I tried removing one Still building, leaving one behind. Plump Helmets then regained its 'BREW' option. I have two dwarfs selected as brewers but they'd rather farm or 'no job'. Brewing fruit and plant is queued with the manager. I removed and rebuilt this last Still but the problem still existed. On to the last step. With the manager queuing 10 fruit and 10 plant brews I added 'brew drink from plant' directly to the Still with 'q'. My brewer is getting to work. Drinks: 3. Waiting to see if this happens again. This is an ongoing issue with the game though. Several dwarfs died of dehydration over the winter before I reloaded a previous save to bring you what I have above. They weren't brewing.

(0030372) Authority2 (reporter) 2014-09-26 04:31	I've had this happen when I only had one plant container containing all my brewable plants in the stockpile. Adding enough plants to fill more barrels or dumping the plants out of the container into a stockpile with barrels disabled let brewing continue. This was in something like 40.05/6, though, so I don't know if it's still the case.

(0030390) drumr (reporter) 2014-09-26 17:09	Observation continued from above: During this whole process I have a stockpile designated for Food and another for Furniture & Finished Goods. Seeds, plants, & fish were visible in the food pile and barrels in the Furniture/Finished pile. There were no barrels in the food stockpile even after the brewer got to work. I watched him retrieve a plant & bring it to the Still and then a barrel. The barrels never left the Still. My drink count was going up and stockpiles were not visually filling with barrels of drinks. The Still would flash a barrel in the lower right corner of the Still, as if it needed to be moved out. A trader arrived and I moved a barrel of fish or wine to the depot along with gems. Sometime during or after this whole trading process my goods were returned to stockpiles in barrels. There were no individual items laying around. This sounds like normal behavior except new brew barrels were not returned to the food stockpile AND the plump helmets were missing the 'BREW' option in the kitchen. I have NOT assigned any barrels anywhere. Will/Should my dwarves auto-fill barrels if they are assigned to the stockpile?

(0032371) Afghani84 (reporter) 2015-03-12 19:13	I don't know if this is still an issue for some people. I encountered the same problem as well and found an easy solution to it. I had a furniture stockpile with empty barrels (linked to the still) and another stockpile for brewable plants (not linked). Once I linked the plant stockpile to the still, it worked just fine.

(0035970) 4maskwolf (reporter) 2016-10-10 17:00	I haven't seen any problems of this kind since at least .42, has anyone else run across this or has this one been fixed?

(0035972) Loci (manager) 2016-10-11 19:12	This report became a catch-all for vague brewing problems. There are still outstanding bugs that interfere with brewing (0007423, 0009004), but much of this report is now outdated and nothing appears actionable.

Issue History
Date Modified	Username	Field	Change
2014-07-17 23:19	Footkerchief	New Issue
2014-07-17 23:19	Footkerchief	Status	new => assigned
2014-07-17 23:19	Footkerchief	Assigned To	=> Footkerchief
2014-07-17 23:19	Footkerchief	Issue generated from	0006784
2014-07-18 01:16	jpcosta	Issue Monitored: jpcosta
2014-07-18 02:12	Khym Chanur	Note Added: 0026847
2014-07-18 07:43	Footkerchief	Note Added: 0026858
2014-07-18 07:53	Footkerchief	Note Edited: 0026858	View Revisions
2014-07-18 07:53	Footkerchief	Status	assigned => needs feedback
2014-07-18 07:55	Footkerchief	Relationship added	related to 0006849
2014-07-18 07:55	Footkerchief	Relationship added	related to 0000434
2014-07-18 07:57	Footkerchief	Relationship added	related to 0006784
2014-07-20 16:56	Dwarfu	Relationship added	has duplicate 0007517
2014-07-21 02:29	Vuliatis	Note Added: 0027109
2014-07-21 02:37	Vuliatis	Note Edited: 0027109	View Revisions
2014-07-21 02:37	Vuliatis	Note Deleted: 0027109
2014-07-23 12:34	Knight Otu	Note Added: 0027342
2014-07-26 09:14	Dwarfu	Relationship added	parent of 0007645
2014-07-26 09:14	Dwarfu	Relationship deleted	parent of 0007645
2014-07-26 09:17	Dwarfu	Note Added: 0027617
2014-07-26 09:18	Dwarfu	Relationship added	parent of 0007645
2014-07-27 14:59	torrenal	Note Added: 0027713
2014-07-27 15:00	torrenal	Issue Monitored: torrenal
2014-07-27 15:04	Footkerchief	Note Added: 0027717
2014-07-27 15:04	Footkerchief	Status	needs feedback => assigned
2014-07-27 15:04	Footkerchief	Note Edited: 0027717	View Revisions
2014-07-27 15:06	Footkerchief	Note Edited: 0027717	View Revisions
2014-07-27 15:35	torrenal	Note Added: 0027726
2014-08-04 18:21	Dwarfu	Relationship added	has duplicate 0007844
2014-08-04 19:12	4maskwolf	Issue Monitored: 4maskwolf
2014-08-04 21:39	fortunawhisk	Note Added: 0028351
2014-08-04 21:40	fortunawhisk	Note Edited: 0028351	View Revisions
2014-08-04 21:51	fortunawhisk	Note Edited: 0028351	View Revisions
2014-08-04 21:54	fortunawhisk	Note Edited: 0028351	View Revisions
2014-08-06 03:04	denegor	Issue Monitored: denegor
2014-08-07 15:44	lethosor	Note Added: 0028542
2014-08-07 16:59	Loci	Note Added: 0028545
2014-08-07 17:59	lethosor	Relationship added	has duplicate 0007896
2014-08-07 18:12	Footkerchief	Relationship added	related to 0006940
2014-08-07 18:13	Footkerchief	Relationship added	related to 0005992
2014-08-07 18:14	Footkerchief	Relationship added	related to 0007423
2014-08-07 18:16	Footkerchief	Note Added: 0028554
2014-08-07 18:37	lethosor	Note Added: 0028556
2014-08-07 18:37	lethosor	Note Edited: 0028542	View Revisions
2014-08-09 23:33	torrenal	Note Added: 0028701
2014-08-12 12:22	psisquared	Issue Monitored: psisquared
2014-08-12 12:27	psisquared	Note Added: 0028891
2014-08-12 13:41	fortunawhisk	Note Added: 0028898
2014-08-12 13:45	Loci	Note Added: 0028899
2014-08-12 14:51	fortunawhisk	Note Added: 0028902
2014-08-12 15:57	psisquared	Note Added: 0028903
2014-08-13 22:28	xenofeel	Issue Monitored: xenofeel
2014-08-13 22:36	xenofeel	Issue End Monitor: xenofeel
2014-08-13 22:36	xenofeel	Issue Monitored: xenofeel
2014-08-15 07:06	Footkerchief	Status	assigned => needs feedback
2014-08-20 01:17	JoshuaRaven	Note Added: 0029345
2014-08-20 02:16	Rafal99	Note Added: 0029346
2014-08-20 02:16	Rafal99	Note Edited: 0029346	View Revisions
2014-08-20 02:59	JoshuaRaven	Note Added: 0029349
2014-08-27 20:54	thriggle	Note Added: 0029736
2014-08-28 04:44	Loci	Note Added: 0029740
2014-09-23 17:39	arcosanti	Note Added: 0030336
2014-09-23 17:39	arcosanti	Note Edited: 0030336	View Revisions
2014-09-26 00:20	drumr	Note Added: 0030371
2014-09-26 04:31	Authority2	Note Added: 0030372
2014-09-26 17:09	drumr	Note Added: 0030390
2014-12-08 09:01	Footkerchief	Relationship added	has duplicate 0008608
2014-12-08 09:01	Footkerchief	Issue Monitored: Wokimeittes
2015-03-12 19:13	Afghani84	Note Added: 0032371
2015-03-12 19:13	Afghani84	Issue Monitored: Afghani84
2016-10-10 17:00	4maskwolf	Note Added: 0035970
2016-10-11 06:57	Loci	Relationship added	related to 0009004
2016-10-11 19:12	Loci	Note Added: 0035972
2016-10-11 19:12	Loci	Status	needs feedback => resolved
2016-10-11 19:12	Loci	Resolution	open => unable to reproduce
2016-10-11 19:12	Loci	Assigned To	Footkerchief => Loci
2016-10-24 11:59	4maskwolf	Issue End Monitor: 4maskwolf
2017-01-09 15:25	Afghani84	Issue End Monitor: Afghani84