0001332: Olivine doors look like gems - Dwarf Fortress Bug Tracker

(0004229)
smjjames (reporter)
2010-04-19 08:09

It might be a graphical thing, are you using any graphics pack or is that vanilla DF?

(0004240)
Footkerchief (manager)
2010-04-19 09:45

Doors have historically had display problems:
http://www.bay12games.com/forum/index.php?topic=20917.0 [^]
http://www.bay12games.com/forum/index.php?topic=47756.0 [^]

I'm not sure if display issues tied to quality are new or not. Did you try building a couple more (non-masterwork) olivine doors to see how they showed up?

(0004322)
ray10k (reporter)
2010-04-20 03:35

I did build a lot of non-masterwork doors, all of them just showed up like normal doors.

(0004345)
tel (reporter)
2010-04-20 10:06

This seems to be an issue with olivine doors in general. All of my (non-masterwork) olivine doors look normal when stored, but like gems when installed. They work fine as doors, though.

(0004717)
slink (reporter)
2010-04-23 08:47
edited on: 2010-04-23 08:47

Same here. When installed, all olivine doors appear different from all the other doors, regardless of quality. No graphics pack here.

(0004731)
Footkerchief (manager)
2010-04-23 10:19

Thanks for the info. I updated the summary accordingly.

(0006988)
Quietust (reporter)
2010-05-18 19:17

I've heard of (artifact) GEM doors appearing like gems, but not olivine...

(0007007)
JeffGroves (reporter)
2010-05-19 01:16

Confirmed to still be an issue in 31.04. Olivine doors still look like gems.

(0008819)
sirbruce (reporter)
2010-06-20 18:05

Confirmed in 31.06 and 31.08 from a 31.05 savegame.

(0010257)
Kanddak (reporter)
2010-07-14 15:25
edited on: 2010-07-14 15:25

Having this in 0.31.10, new game started today in .10 install with nothing changed except init files (in various ways) and keybindings (to work around MacOS X delete key -> mountain character bug). Olivine doors look like webs/gems/gears, other doors appear normal. Nothing seems unusual about the raw entry for olivine.

(0010261)
Quietust (reporter)
2010-07-14 17:15

I just tried making doors out of every stone type I could bring with a test embark (everything but siltstone, shale, claystone, dolomite, chalk, talc, obsidian, raw adamantine, and slade), and olivine was the *only* one that appeared as "☼" (gray foreground, green background); all of the others appeared as "┼" (with the appropriate colors).

(0012079)
Quietust (reporter)
2010-08-25 07:41

And now, in my current fortress in 0.31.12, I've built several olivine doors, but all of them appear as normal doors...

(0013110)
krenshala (reporter)
2010-10-01 19:26

Just to add to this one, I'm running 0.31.14 and all five (5) of my olivine doors, none of which are masterwork, look normal in a stockpile but use the masterwork/raw-gem symbol when constructed. The doors work properly, so it just looks odd.

WinXP, 0.31.14 using the Phoebus Graphics Set, if it matters (though Phoebus says he doesn't think its anything he's changed in the configs).

(0013246)
krenshala (reporter)
2010-10-07 17:27
edited on: 2010-10-08 20:24

And to add a new update, in 0.31.16 olivine doors appear to be working correctly (showing the normal rock door symbol both in stockpiles and when constructed) for me.

[edit] damn, started a new 0.31.16 fort and olivine doors have gone back to looking like gems/masterwork symbol when constructed. This time it was next to an olivine wall, and I do not believe that was the case when I got the doors that appeared 'normal' earlier in this comment.

(0018577)
Quietust (reporter)
2011-08-19 08:47
edited on: 2011-08-19 08:52

A recently-posted movie on DFMA (http://mkv25.net/dfma/movie-2360 [^]) illustrates doors made of rose gold exhibiting this problem, and I've personally confirmed this with a vanilla test fortress in version 0.31.25.

(0019034)
Quietust (reporter)
2011-11-25 15:01
edited on: 2011-11-25 15:02

With a bit of debugging, I've managed to locate the source of this problem: it's exactly the same as the problem in 0001498, a function/macro being called with its parameters in the wrong order, resulting in doors being displayed as ☼ if the Nth material (where N is the inorganic material ID, 0/1/2/etc for IRON/COPPER/SILVER/etc) belong to creature 31 (BIRD_GUINEAFOWL) is made of BONE.

The following binary patch (for Win32 DF 0.31.25 SDL) will fix the display of gem doors:

0x056E42 : 00 B8 30 -> 30 BA 00
0x056E48 : 66 -> 90
0x056E4A : D5 -> C5

(push 00 | mov eax,00000030 | mov dx,bp -> push 30 | mov edx,00000000 | nop | mov eax,ebp)

Note that this does NOT correct the problem of metal doors failing to display as ╪, as this is seemingly due to the code being missing altogether.

(0019448)
Quietust (reporter)
2012-02-01 10:15

Binary patch for version 0.31.25 Linux: (untested)
44069 : 0C -> 04
44071 : 04 -> 08
4407C : 08 -> 0C

(0019805)
Quietust (reporter)
2012-02-16 09:09

Still broken in version 0.34.01 - while exploring a law-giver's keep, I found a rose gold door that looked like a gem.

(0019861)
Toady One (administrator)
2012-02-16 16:35

Sorted for next time. Thanks Quietust!

Issue History
Date Modified	Username	Field	Change
2010-04-19 07:40	ray10k	New Issue
2010-04-19 08:09	smjjames	Note Added: 0004229
2010-04-19 09:45	Footkerchief	Note Added: 0004240
2010-04-19 09:46	Footkerchief	Issue Monitored: Footkerchief
2010-04-19 10:02	Kennel	Tag Attached: door
2010-04-20 03:35	ray10k	Note Added: 0004322
2010-04-20 10:06	tel	Note Added: 0004345
2010-04-23 08:47	slink	Note Added: 0004717
2010-04-23 08:47	slink	Note Edited: 0004717	View Revisions
2010-04-23 10:19	Footkerchief	Summary	masterwork door looks different => Olivine doors look like gems
2010-04-23 10:19	Footkerchief	Note Added: 0004731
2010-05-18 19:14	Footkerchief	Relationship added	has duplicate 0001962
2010-05-18 19:17	Quietust	Note Added: 0006988
2010-05-19 01:16	JeffGroves	Note Added: 0007007
2010-06-20 18:05	sirbruce	Note Added: 0008819
2010-07-14 15:25	Kanddak	Note Added: 0010257
2010-07-14 15:25	Kanddak	Note Edited: 0010257	View Revisions
2010-07-14 17:15	Quietust	Note Added: 0010261
2010-07-31 11:41	Footkerchief	Relationship added	related to 0002589
2010-08-25 07:41	Quietust	Note Added: 0012079
2010-10-01 19:26	krenshala	Note Added: 0013110
2010-10-07 17:27	krenshala	Note Added: 0013246
2010-10-08 20:24	krenshala	Note Edited: 0013246	View Revisions
2011-08-19 08:47	Quietust	Note Added: 0018577
2011-08-19 08:52	Quietust	Note Edited: 0018577	View Revisions
2011-11-25 15:01	Quietust	Note Added: 0019034
2011-11-25 15:01	Quietust	Note Edited: 0019034	View Revisions
2011-11-25 15:02	Quietust	Note Edited: 0019034	View Revisions
2011-11-25 19:55	Quietust	Tag Attached: binary patch
2012-01-10 18:25	Footkerchief	Relationship added	related to 0003099
2012-02-01 10:15	Quietust	Note Added: 0019448
2012-02-16 09:09	Quietust	Note Added: 0019805
2012-02-16 16:35	Toady One	Note Added: 0019861
2012-02-16 16:35	Toady One	Status	new => resolved
2012-02-16 16:35	Toady One	Fixed in Version	=> Next Version
2012-02-16 16:35	Toady One	Resolution	open => fixed
2012-02-16 16:35	Toady One	Assigned To	=> Toady One
2014-01-15 14:50	Kirig Stonebeard II	Issue Monitored: Kirig Stonebeard II
2014-01-17 10:03	Kirig Stonebeard	Issue Monitored: Kirig Stonebeard

Notes
(0004229) smjjames (reporter) 2010-04-19 08:09	It might be a graphical thing, are you using any graphics pack or is that vanilla DF?

(0004240) Footkerchief (manager) 2010-04-19 09:45	Doors have historically had display problems: http://www.bay12games.com/forum/index.php?topic=20917.0 [^] http://www.bay12games.com/forum/index.php?topic=47756.0 [^] I'm not sure if display issues tied to quality are new or not. Did you try building a couple more (non-masterwork) olivine doors to see how they showed up?

(0004322) ray10k (reporter) 2010-04-20 03:35	I did build a lot of non-masterwork doors, all of them just showed up like normal doors.

(0004345) tel (reporter) 2010-04-20 10:06	This seems to be an issue with olivine doors in general. All of my (non-masterwork) olivine doors look normal when stored, but like gems when installed. They work fine as doors, though.

(0004717) slink (reporter) 2010-04-23 08:47 edited on: 2010-04-23 08:47	Same here. When installed, all olivine doors appear different from all the other doors, regardless of quality. No graphics pack here.

(0004731) Footkerchief (manager) 2010-04-23 10:19	Thanks for the info. I updated the summary accordingly.

(0006988) Quietust (reporter) 2010-05-18 19:17	I've heard of (artifact) GEM doors appearing like gems, but not olivine...

(0007007) JeffGroves (reporter) 2010-05-19 01:16	Confirmed to still be an issue in 31.04. Olivine doors still look like gems.

(0008819) sirbruce (reporter) 2010-06-20 18:05	Confirmed in 31.06 and 31.08 from a 31.05 savegame.

(0010257) Kanddak (reporter) 2010-07-14 15:25 edited on: 2010-07-14 15:25	Having this in 0.31.10, new game started today in .10 install with nothing changed except init files (in various ways) and keybindings (to work around MacOS X delete key -> mountain character bug). Olivine doors look like webs/gems/gears, other doors appear normal. Nothing seems unusual about the raw entry for olivine.

(0010261) Quietust (reporter) 2010-07-14 17:15	I just tried making doors out of every stone type I could bring with a test embark (everything but siltstone, shale, claystone, dolomite, chalk, talc, obsidian, raw adamantine, and slade), and olivine was the only one that appeared as "☼" (gray foreground, green background); all of the others appeared as "┼" (with the appropriate colors).

(0012079) Quietust (reporter) 2010-08-25 07:41	And now, in my current fortress in 0.31.12, I've built several olivine doors, but all of them appear as normal doors...

(0013110) krenshala (reporter) 2010-10-01 19:26	Just to add to this one, I'm running 0.31.14 and all five (5) of my olivine doors, none of which are masterwork, look normal in a stockpile but use the masterwork/raw-gem symbol when constructed. The doors work properly, so it just looks odd. WinXP, 0.31.14 using the Phoebus Graphics Set, if it matters (though Phoebus says he doesn't think its anything he's changed in the configs).

(0013246) krenshala (reporter) 2010-10-07 17:27 edited on: 2010-10-08 20:24	And to add a new update, in 0.31.16 olivine doors appear to be working correctly (showing the normal rock door symbol both in stockpiles and when constructed) for me. [edit] damn, started a new 0.31.16 fort and olivine doors have gone back to looking like gems/masterwork symbol when constructed. This time it was next to an olivine wall, and I do not believe that was the case when I got the doors that appeared 'normal' earlier in this comment.

(0018577) Quietust (reporter) 2011-08-19 08:47 edited on: 2011-08-19 08:52	A recently-posted movie on DFMA (http://mkv25.net/dfma/movie-2360 [^]) illustrates doors made of rose gold exhibiting this problem, and I've personally confirmed this with a vanilla test fortress in version 0.31.25.

(0019034) Quietust (reporter) 2011-11-25 15:01 edited on: 2011-11-25 15:02	With a bit of debugging, I've managed to locate the source of this problem: it's exactly the same as the problem in 0001498, a function/macro being called with its parameters in the wrong order, resulting in doors being displayed as ☼ if the Nth material (where N is the inorganic material ID, 0/1/2/etc for IRON/COPPER/SILVER/etc) belong to creature 31 (BIRD_GUINEAFOWL) is made of BONE. The following binary patch (for Win32 DF 0.31.25 SDL) will fix the display of gem doors: 0x056E42 : 00 B8 30 -> 30 BA 00 0x056E48 : 66 -> 90 0x056E4A : D5 -> C5 (push 00 \| mov eax,00000030 \| mov dx,bp -> push 30 \| mov edx,00000000 \| nop \| mov eax,ebp) Note that this does NOT correct the problem of metal doors failing to display as ╪, as this is seemingly due to the code being missing altogether.

(0019448) Quietust (reporter) 2012-02-01 10:15	Binary patch for version 0.31.25 Linux: (untested) 44069 : 0C -> 04 44071 : 04 -> 08 4407C : 08 -> 0C

(0019805) Quietust (reporter) 2012-02-16 09:09	Still broken in version 0.34.01 - while exploring a law-giver's keep, I found a rose gold door that looked like a gem.

(0019861) Toady One (administrator) 2012-02-16 16:35	Sorted for next time. Thanks Quietust!