0000433: Elves bring massive caravan and cause game crash

(0000968)
gregb (reporter)
2010-04-04 18:21

should probably be noted that there was no elven liaison or diplomat with the caravan.

(0001001)
savanik (reporter)
2010-04-04 22:32

I don't believe there ever has been an elven liaison or diplomat, even in the last version.

(0001025)
Footkerchief (manager)
2010-04-05 00:13

Might be helpful if you post the save that you've been using to reproduce this.

(0001029)
gregb (reporter)
2010-04-05 00:24
edited on: 2010-04-05 00:25

I would, but I scrapped the fort and started over. I'll remember to post the save it happens again in the new fort or if any other bugs come up.

(0001478)
Rafal99 (reporter)
2010-04-06 09:23

I have the similar situation except that no crash.
Elves came in the next spring, with 2 merchants and 2 warthogs. I don't know if warthogs are even supposed to be trade animal, they have no [TRADE_CAPACITY] tag.

They brought about 100 page of goods total, 5+ pages of every type of stuff (ropes, cages, buckets etc.)

No crash during the whole process.
I might dig an old save if needed.

Tried killing the elves with militia too, and no success, they just followed the elves.

(0001485)
Rafal99 (reporter)
2010-04-06 09:28

The bug is here too: http://www.bay12games.com/dwarves/mantisbt/view.php?id=325 [^]

(0002282)
Langdon (reporter)
2010-04-09 02:37

I can confirm that warthogs lack the [TRADE_CAPACITY] tag, which may be the cause of the huge elf caravans.

I am genning and starting a new game with [TRADE_CAPACITY] added to the warthogs, just to check if it reduces (or removes) the regular crashes I've been seeing.

(0002309)
Rafal99 (reporter)
2010-04-09 05:25

I tried removing [PACK_ANIMAL] from Warthogs, but elves still came with them, except that this time they were empty, no goods to trade.

(0002406)
Langdon (reporter)
2010-04-09 13:10

Playing in a new game genned on 0.31.02, with [TRADE_CAPACITY:600] added to the warthog entry, I can confirm that elven caravans now bring a sane amount of goods.

It should probably be upped to [TRADE_CAPACITY:3000] to match the default camel trade capacity.

(0002651)
Rafal99 (reporter)
2010-04-10 14:46

Well do you know what warthog is?
http://en.wikipedia.org/wiki/Warthog [^]

It seems strange to me that they are marked as pack animals at all. If anything I would give them less capacity than donkey, which have 1500, and warthogs are smaller.

(0003380)
Arkaaito (reporter)
2010-04-13 20:17

The crash is probably due to a memory issue (see bug 2 or 136 for an example). If it happens again, you may want to watch memory usage and see if the crash comes right as it hits 2GB (if you're on a system with > 2GB) or your overall hits 100%.

(0007976)
Toady One (administrator)
2010-06-09 01:04

The warthogs were the only pack animals I found without a trade capacity, and the common domestic and pack animal tags were there by mistake (copy-paste error, most likely). I also put a non-trade-capacity item number cap and default trade capacities for all creatures, so this should be handled for 0.31.06.

Issue History
Date Modified	Username	Field	Change
2010-04-04 18:00	gregb	New Issue
2010-04-04 18:18	Qloos	Tag Attached: trade
2010-04-04 18:18	Qloos	Tag Attached: Elves
2010-04-04 18:20	gregb	Issue Monitored: gregb
2010-04-04 18:21	gregb	Note Added: 0000968
2010-04-04 22:32	savanik	Note Added: 0001001
2010-04-05 00:13	Footkerchief	Note Added: 0001025
2010-04-05 00:24	gregb	Note Added: 0001029
2010-04-05 00:25	gregb	Note Edited: 0001029	View Revisions
2010-04-06 09:23	Rafal99	Note Added: 0001478
2010-04-06 09:28	Rafal99	Note Added: 0001485
2010-04-06 09:51	Rafal99	Issue Monitored: Rafal99
2010-04-06 09:54	Footkerchief	Relationship added	parent of 0000325
2010-04-07 08:07	Rafal99	Tag Attached: caravan
2010-04-09 02:37	Langdon	Note Added: 0002282
2010-04-09 02:52	Langdon	Issue Monitored: Langdon
2010-04-09 03:56	Khym Chanur	Issue Monitored: Khym Chanur
2010-04-09 05:25	Rafal99	Note Added: 0002309
2010-04-09 13:10	Langdon	Note Added: 0002406
2010-04-10 14:46	Rafal99	Note Added: 0002651
2010-04-13 06:50	HazelrahBL	Issue Monitored: HazelrahBL
2010-04-13 20:17	Arkaaito	Note Added: 0003380
2010-04-15 08:54	Footkerchief	Relationship replaced	child of 0000325
2010-05-02 16:04	Logical2u	Relationship added	related to 0001705
2010-06-09 01:04	Toady One	Note Added: 0007976
2010-06-09 01:04	Toady One	Status	new => resolved
2010-06-09 01:04	Toady One	Fixed in Version	=> 0.31.06
2010-06-09 01:04	Toady One	Resolution	open => fixed
2010-06-09 01:04	Toady One	Assigned To	=> Toady One
2010-06-09 06:01	Rafal99	Issue End Monitor: Rafal99
2010-06-09 06:45	Toady One	Status	resolved => closed
2010-06-09 07:56	Footkerchief	Status	closed => resolved
2010-06-10 20:34	Langdon	Issue End Monitor: Langdon
2010-06-11 12:08	Khym Chanur	Issue End Monitor: Khym Chanur
2010-06-12 17:26	HazelrahBL	Issue End Monitor: HazelrahBL

Notes
(0000968) gregb (reporter) 2010-04-04 18:21	should probably be noted that there was no elven liaison or diplomat with the caravan.

(0001001) savanik (reporter) 2010-04-04 22:32	I don't believe there ever has been an elven liaison or diplomat, even in the last version.

(0001025) Footkerchief (manager) 2010-04-05 00:13	Might be helpful if you post the save that you've been using to reproduce this.

(0001029) gregb (reporter) 2010-04-05 00:24 edited on: 2010-04-05 00:25	I would, but I scrapped the fort and started over. I'll remember to post the save it happens again in the new fort or if any other bugs come up.

(0001478) Rafal99 (reporter) 2010-04-06 09:23	I have the similar situation except that no crash. Elves came in the next spring, with 2 merchants and 2 warthogs. I don't know if warthogs are even supposed to be trade animal, they have no [TRADE_CAPACITY] tag. They brought about 100 page of goods total, 5+ pages of every type of stuff (ropes, cages, buckets etc.) No crash during the whole process. I might dig an old save if needed. Tried killing the elves with militia too, and no success, they just followed the elves.

(0001485) Rafal99 (reporter) 2010-04-06 09:28	The bug is here too: http://www.bay12games.com/dwarves/mantisbt/view.php?id=325 [^]

(0002282) Langdon (reporter) 2010-04-09 02:37	I can confirm that warthogs lack the [TRADE_CAPACITY] tag, which may be the cause of the huge elf caravans. I am genning and starting a new game with [TRADE_CAPACITY] added to the warthogs, just to check if it reduces (or removes) the regular crashes I've been seeing.

(0002309) Rafal99 (reporter) 2010-04-09 05:25	I tried removing [PACK_ANIMAL] from Warthogs, but elves still came with them, except that this time they were empty, no goods to trade.

(0002406) Langdon (reporter) 2010-04-09 13:10	Playing in a new game genned on 0.31.02, with [TRADE_CAPACITY:600] added to the warthog entry, I can confirm that elven caravans now bring a sane amount of goods. It should probably be upped to [TRADE_CAPACITY:3000] to match the default camel trade capacity.

(0002651) Rafal99 (reporter) 2010-04-10 14:46	Well do you know what warthog is? http://en.wikipedia.org/wiki/Warthog [^] It seems strange to me that they are marked as pack animals at all. If anything I would give them less capacity than donkey, which have 1500, and warthogs are smaller.

(0003380) Arkaaito (reporter) 2010-04-13 20:17	The crash is probably due to a memory issue (see bug 2 or 136 for an example). If it happens again, you may want to watch memory usage and see if the crash comes right as it hits 2GB (if you're on a system with > 2GB) or your overall hits 100%.

(0007976) Toady One (administrator) 2010-06-09 01:04	The warthogs were the only pack animals I found without a trade capacity, and the common domestic and pack animal tags were there by mistake (copy-paste error, most likely). I also put a non-trade-capacity item number cap and default trade capacities for all creatures, so this should be handled for 0.31.06.