0008719: Building constructions over parts of trees crashes

Issue History
Date Modified	Username	Field	Change
2015-01-10 10:37	ptb_ptb	New Issue
2015-01-10 10:45	ptb_ptb	Note Added: 0031852
2015-01-11 19:20	Footkerchief	Relationship added	has duplicate 0008723
2015-01-11 19:21	Footkerchief	Assigned To	=> Footkerchief
2015-01-11 19:21	Footkerchief	Status	new => confirmed
2015-01-15 07:04	Footkerchief	Relationship added	related to 0006530
2015-01-17 05:13	lethosor	Relationship added	has duplicate 0008746
2015-01-17 05:15	lethosor	Summary	Building a floor over an underground tree ramp causes crash => Building floors over parts of trees crashes
2015-01-17 05:15	lethosor	Additional Information Updated	View Revisions
2015-01-17 05:17	lethosor	Additional Information Updated	View Revisions
2015-01-24 08:00	txtsd	Issue Monitored: txtsd
2015-01-24 14:41	Footkerchief	Relationship added	has duplicate 0008763
2015-01-24 15:23	lethosor	Additional Information Updated	View Revisions
2015-02-02 20:14	lethosor	Relationship added	related to 0008783
2015-02-02 20:15	lethosor	Relationship replaced	has duplicate 0008783
2015-02-02 20:16	lethosor	Issue Monitored: RainbowTrout
2015-02-02 20:16	lethosor	Summary	Building floors over parts of trees crashes => Building constructions over parts of trees crashes
2015-02-05 08:40	Meneth	Issue Monitored: Meneth
2015-02-05 11:01	se5a	Note Added: 0032151
2015-02-05 11:02	se5a	Note Edited: 0032151	View Revisions
2015-02-05 15:07	RedDwarfStepper	Issue Monitored: RedDwarfStepper
2015-02-05 18:10	lethosor	Relationship added	has duplicate 0008791
2015-02-09 00:19	ptb_ptb	Note Added: 0032190
2015-02-09 12:53	lethosor	Relationship added	has duplicate 0008803
2015-02-09 18:47	lethosor	Relationship added	has duplicate 0008810
2015-02-11 18:14	lethosor	Sticky Issue	No => Yes
2015-02-11 18:15	lethosor	Severity	minor => crash
2015-02-16 08:37	Manae	Note Added: 0032230
2015-02-16 08:49	lethosor	Note Added: 0032231
2015-02-16 08:51	lethosor	Description Updated	View Revisions
2015-02-16 08:51	lethosor	Steps to Reproduce Updated	View Revisions
2015-02-16 08:51	lethosor	Note Edited: 0032231	View Revisions
2015-02-16 08:51	lethosor	Note Edited: 0032231	View Revisions
2015-02-20 11:04	Dwarfu	Relationship added	has duplicate 0008821
2015-02-23 01:52	Dwarfu	Relationship added	has duplicate 0008832
2015-02-27 03:02	Dwarfu	Relationship added	has duplicate 0008835
2015-03-12 21:42	Dwarfu	Relationship added	has duplicate 0008854
2015-03-12 21:42	Dwarfu	Issue Monitored: zerothe3rd
2015-03-26 07:40	Afghani84	Issue Monitored: Afghani84
2015-03-26 13:14	Knight Otu	Relationship added	has duplicate 0008875
2015-03-29 07:54	Footkerchief	Relationship added	has duplicate 0008872
2015-03-29 08:17	Footkerchief	Relationship added	has duplicate 0008740
2015-03-29 18:04	Dwarfu	Relationship added	has duplicate 0008884
2015-04-19 12:17	Knight Otu	Relationship added	has duplicate 0008919
2015-04-19 13:01	Knight Otu	Relationship added	has duplicate 0008920
2015-04-19 14:16	Knight Otu	Relationship added	has duplicate 0008921
2015-05-05 12:43	clanl	Issue Monitored: clanl
2015-05-06 14:22	lethosor	Relationship added	has duplicate 0008948
2015-05-25 07:30	Qrox	Note Added: 0032730
2015-05-25 07:41	Qrox	Note Edited: 0032730	View Revisions
2015-05-25 07:51	Qrox	Note Edited: 0032730	View Revisions
2015-05-25 14:03	lethosor	Relationship added	has duplicate 0008973
2015-05-25 14:03	lethosor	Issue Monitored: dragoon508
2015-05-25 14:04	lethosor	Additional Information Updated	View Revisions
2015-05-25 18:35	Qrox	Note Edited: 0032730	View Revisions
2015-05-31 01:14	Knight Otu	Relationship added	has duplicate 0008981
2015-06-14 09:35	lethosor	Relationship added	related to 0006551
2015-06-18 12:21	max5212	Issue Monitored: max5212
2015-06-18 12:21	max5212	Issue End Monitor: max5212
2015-06-19 08:48	lethosor	Tag Attached: binary patch
2015-06-19 10:54	lethosor	Note Edited: 0032730	View Revisions
2015-06-19 12:38	krenshala	Issue Monitored: krenshala
2015-07-25 17:18	lethosor	Relationship added	has duplicate 0009028
2015-07-25 17:18	lethosor	Additional Information Updated	View Revisions
2015-08-23 06:26	mskala	Note Added: 0032990
2015-09-16 13:59	lethosor	Relationship added	has duplicate 0009070
2015-09-16 14:00	lethosor	Additional Information Updated	View Revisions
2015-10-26 14:10	lethosor	Relationship added	has duplicate 0009104
2015-10-26 14:10	lethosor	Additional Information Updated	View Revisions
2015-11-27 02:02	Knight Otu	Relationship added	has duplicate 0009119
2015-11-28 07:23	lethosor	Relationship added	has duplicate 0009122
2015-11-28 07:24	lethosor	Additional Information Updated	View Revisions
2015-12-02 15:39	Toady One	Status	confirmed => resolved
2015-12-02 15:39	Toady One	Fixed in Version	=> Next Version
2015-12-02 15:39	Toady One	Resolution	open => fixed
2015-12-02 15:39	Toady One	Assigned To	Footkerchief => Toady One
2015-12-13 05:10	clanl	Issue End Monitor: clanl
2015-12-27 13:38	Dwarfu	Sticky Issue	Yes => No
2016-01-03 06:11	Afghani84	Issue End Monitor: Afghani84
2016-04-10 02:45	Knight Otu	Relationship added	has duplicate 0009687
2016-08-08 18:15	krenshala	Issue End Monitor: krenshala
2016-12-06 16:05	Loci	Relationship added	has duplicate 0008934

Notes
(0031852) ptb_ptb (reporter) 2015-01-10 10:45	Save file: http://dffd.wimbli.com/file.php?id=10414 [^]

(0032151) se5a (reporter) 2015-02-05 11:01 edited on: 2015-02-05 11:02	can we up the severity on this? it's happening really frequently for me, remembering to ensure spots I'm trying to construct on don't have leaves, twigs etc growing on them is not easy. also the description needs to be changed on this, it's not just underground trees.

(0032190) ptb_ptb (reporter) 2015-02-09 00:19	Just a note that if you _want_ fungus trees to vanish, you can use this bug 0008799

(0032230) Manae (reporter) 2015-02-16 08:37	To add to this bug, since the related bugs are considered duplicates: There is also a crash if you attempt to build over tree parts above ground. I attempted to build some stone floor on a tile currently occupied by twigs, and it crashes the game. Testing proves that it is the act of building on the tile itself, and not due to eager dwarves crossing tree branches to build on that tile early which would force the tree to support the construction.

(0032231) lethosor (manager) 2015-02-16 08:49 edited on: 2015-02-16 08:51	se5a: The "severity" field is not used to prioritize issues at all - I only changed it to reflect the fact that this bug causes a crash. Manae: Going by the title of this report, that is the same issue (although the description doesn't accurately reflect this). Edit: updated description.

(0032730) Qrox (reporter) 2015-05-25 07:30 edited on: 2015-06-19 10:54	I just did some quick look into the game binary and have (probably) found the cause of the bug and a way to fix it. In Windows DF SDL 40.24, at dwarf fortress.exe+8F7174, inside a loop which seems to be intended to extirpate the tree, a function which is likely to be destroying all buildings built on the tree also deletes pending construction designations (which is a "building", in terms of game data structure). This also deletes the construction being finished and results in a hanging reference to it, and when the game later calls a virtual function of the structure, the vtable pointer has already been overwritten, causing a failed function call, which causes a segmentation fault. (Yeah, the good old delete object at a wrong time -> hanging reference thing). A fix for this would be that just ignore any construction designation on the tree when destroying buildings on the tree. A better fix for this would be not destroying the whole tree, but rather changing the construction designation into construction, and then remove the tile from the tree's structural data. This way you don't even need to destruct any buildings on the tree since the only tile changed is the tile of the construction, plus a possible down slope if the tile was an up slope, a down slope if the construction is an up slope, a floor if the construction is a wall, and down slopes don't support any sort of buildings, and a new down slope or floor will not cause a building to collapse. A binary fix for Windows SDL 0.40.24 is available. Just change Dwarf Fortress.exe+8F7165 from 74 12 (je +12) to EB 12 (jmp +12). This reduces this bug from a crash to some weird behaviour (cut tree vanishes, leaving buildings on it floating in air. But weird behaviour is better than a crash isn't it?). Of course, these are all done in a hurry and I do not guarantee they are 100% correct, nor do I guarantee the safety of the fix and am not responsible of any harm that might be done to your beloved dorfs using this method.

(0032990) mskala (reporter) 2015-08-23 06:26	I have a game that crashed repeatedly, cause unknown but it was while floor-building in tree foliage was designated, so most likely it was this issue causing the crash, when the dwarfs eventually got around to building those floors. However, on the most recent attempt, they succeeded in building the floor, with strange results. This was a fungiwood tree growing in a lake on the first cavern level. The second cavern level was very close to the first at that point, so on successive Z-levels top to bottom, we had: 1. foliage with floors designated for construction; 2. lake (7/7 water) and the fungiwood trunk; 3. open space of the second cavern layer. When the dwarves built the floor, the entire tree vanished, leaving a cell of open space on the lake level where its trunk had been. No floor. That created an opening to the second cavern layer, and a dwarf fell through the hole, landing on a mushroom cap a couple Z-levels further down. However, the 7/7 water surrounding the open space did not flow into the space. I have a cell of dry open space connecting to the next layer, surrounded by 7/7 water.